Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update websocket lib, fix race on close #33

Merged
merged 1 commit into from Jan 5, 2021

Conversation

ccbrown
Copy link
Owner

@ccbrown ccbrown commented Jan 5, 2021

What it Does

Steps to Test

go test -v ./...

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #33 (89f0701) into master (0ad8e9e) will increase coverage by 0.05%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   81.94%   82.00%   +0.05%     
==========================================
  Files          52       52              
  Lines        3988     3995       +7     
==========================================
+ Hits         3268     3276       +8     
+ Misses        463      462       -1     
  Partials      257      257              
Impacted Files Coverage Δ
graphqlws/connection.go 60.97% <60.00%> (+1.10%) ⬆️
graphqlws.go 67.85% <0.00%> (+2.38%) ⬆️

@ccbrown ccbrown merged commit 362fccd into master Jan 5, 2021
@ccbrown ccbrown deleted the update-gorilla-websocket-fix-race branch January 5, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant