Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some game metadata #6

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Add some game metadata #6

merged 2 commits into from
Apr 18, 2022

Conversation

AstraLuma
Copy link
Contributor

@AstraLuma AstraLuma commented Apr 18, 2022

Adds some data to the samples dump to help other kinds of forwarder:

  • the tick count, so we have a sense of absolute game time
  • the entity ID of the combinator, so duplicate names can be tracked, if reasonable
  • the surface name of the combinator

closes #4

closes #5

@ccbrown ccbrown self-requested a review April 18, 2022 06:45
control.lua Outdated Show resolved Hide resolved
@ccbrown
Copy link
Owner

ccbrown commented Apr 18, 2022

Thanks for the PR! In general, I'm happy to publish updates with additional data in the samples file as long as it's reasonably lightweight. Just one suggestion on this. Let me know if that works for you.

Co-authored-by: Chris <ccbrown112@gmail.com>
@AstraLuma
Copy link
Contributor Author

Thank you, yeah, your suggestion is fine.

@ccbrown ccbrown merged commit e120c13 into ccbrown:main Apr 18, 2022
@AstraLuma AstraLuma mentioned this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unit Number To Samples Add Tick Count To Samples
2 participants