Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of NATSymmetricUDPFirewall #33

Open
olifre opened this issue Aug 6, 2019 · 2 comments

Comments

@olifre
Copy link

commented Aug 6, 2019

It took me a while to understand that NATSymmetricUDPFirewall actually means Symmetric UDP Firewall without any actual NAT being involved (as is also shown in the RFC and the flow chart in https://github.com/ccding/go-stun/blob/master/stun/discover.go ).

I wonder whether this constant should be renamed / aliased to SymmetricUDPFirewall to better clarify that this is very different from NATSymmetric ?

@xiang90

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

@olifre

can you send a PR to fix this?

@olifre

This comment has been minimized.

Copy link
Author

commented Aug 12, 2019

@xiang90 In principle yes, but there are two problems:

  • I don't know if there should be an alias (for a while?) to not break API compatibilitiy with other users (e.g. syncthing) hard.
  • I basically only know Go well enough to read it, so I would only be able to do a search / replace (but well, that's really sufficient here I think 😉 ).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.