Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English web interface #15

Closed
l2dy opened this issue Mar 23, 2020 · 5 comments
Closed

English web interface #15

l2dy opened this issue Mar 23, 2020 · 5 comments
Assignees
@jsers
Labels
enhancement New feature or request

Comments

@l2dy
Copy link

l2dy commented Mar 23, 2020

Please support i18n in the web interface, and add English translation.

Default language preference should be configurable.
@UlricQin
Copy link
Member

Relevant work is in progress.

@UlricQin UlricQin added the enhancement New feature or request label Mar 26, 2020
@thtantos
Copy link

I want an event

@jsers
Copy link
Contributor

jsers commented Apr 2, 2020

English translation is supported, and other languages require community support.

@jsers jsers closed this as completed Apr 2, 2020
@jsers
Copy link
Contributor

jsers commented Apr 2, 2020

The default language by navigator.language

@l2dy
Copy link
Author

l2dy commented Apr 2, 2020 •
edited
Loading

English translation is supported, and other languages require community support.

Thanks! English translation is not complete though.

https://github.com/didi/nightingale/blob/c7e50f223de52a95e8ce8998725da87edb4791f7/web/src/components/Layout/NsTree.tsx#L45

https://github.com/didi/nightingale/blob/c7e50f223de52a95e8ce8998725da87edb4791f7/web/src/pages/Monitor/History/List.tsx#L361

https://github.com/didi/nightingale/blob/c7e50f223de52a95e8ce8998725da87edb4791f7/web/src/components/Layout/index.tsx#L320-L324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsers jsers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@UlricQin @jsers @l2dy @thtantos