Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes issue when parsing some cookies #30

Merged
merged 1 commit into from Feb 29, 2012

Conversation

Projects
None yet
2 participants
Contributor

canassa commented Feb 24, 2012

The current create-cookies function assumes that the 'set-cookie' header is always a vector.

I find out that this is not always true. If the response from the server contains a single 'set-cookie', the 'set-cookie' entry in the header map will be a string instead of a vector. This generates a java exception when the create-cookies function is called.

I wrote a new test to catch this scenario and changed the 'create-cookie' function to handle it.

Disclamer: I am Clojure newbie! I hope that everything is okay!

Thanks for the work you put on this library.

Cesar Canassa

Collaborator

neotyk commented Feb 24, 2012

Thank you for the patch!

I've already merged it to development branch and pushed snapshot to clojars.
Will create release for it later today.

@neotyk neotyk merged commit e139a02 into cch1:master Feb 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment