Fix method generation in WrappedDistinguishedName. #37

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@scepticulous

Without this patch the initializer used downcase to cast the x509 subject entry into a method.
This led to emailAddress being converted to emailaddress, but the classes method is called email_address.
This patch introduces a underscore method that can convert camal-cased entries from x509 subects into
underscore instance methods.
Also added tests for email_address access to DistinguishedName unit tests

@scepticulous scepticulous Fix method generation in WrappedDistinguishedName.
Without this patch the initializer used downcase to cast the x509 subject entry into a method.
This led to emailAddress being converted to emailaddress, but the classes method is called email_address.
This patch introduces a underscore method that can convert camal-cased entries from x509 subects into
underscore instance methods.
Also added tests for email_address access to DistinguishedName unit tests
59026e0
@cchandler
Owner

Seems reasonable to me.

@scepticulous

is there anything to do before the pull request will be merged?

@cchandler
Owner

I've got a few free hours so I'm going back through my email. If you can fix the merge conflict I'll merge this in today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment