Skip to content

Conversation

@berquist
Copy link
Member

@berquist berquist commented Jul 4, 2024

Closes #1420

cclib/cclib-data#190 should be merged after this PR.

@berquist
Copy link
Member Author

berquist commented Jul 4, 2024

This is failing because the regression testing code no longer allows defining a test that's missing a file. Since this is a common scenario with PRs made to both repos simultaneously, I could change it back to the previous behavior...or we merge cclib-data PRs with the understanding that the next cclib PR has to be the regression fix.

@codecov
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (17e3b62) to head (b55526d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1452   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          73       73           
  Lines       14788    14788           
=======================================
  Hits        12035    12035           
  Misses       2753     2753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berquist berquist merged commit 9dfad1a into cclib:master Jul 20, 2024
@berquist berquist deleted the 1420-gaussian-platform branch July 20, 2024 15:43
@berquist berquist modified the milestones: v2.0a2, v1.8.2 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Getting platform_full_version for Apple M1 Computer

1 participant