Skip to content

Golint #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jul 31, 2017
Merged

Golint #15

merged 36 commits into from
Jul 31, 2017

Conversation

@thraxil
Copy link
Contributor

@thraxil thraxil commented Jul 29, 2017

get the code passing golint

Mostly involves exporting fewer variables and changing variable names from ALL_CAPS to CamelCase and such.

thraxil added 30 commits July 29, 2017 12:18
@thraxil
GRAPHITE_BASE -> GraphiteBase
1c12af8
@thraxil
email_to -> emailTo
ac3b432
@thraxil
CARBON_BASE -> CarbonBase
a519e3f
@thraxil
METRIC_BASE -> MetricBase
3250d89
@thraxil
EMAIL_FROM -> EmailFrom
fdd2029
@thraxil
EMAIL_TO -> EmailTo
ee08be7
@thraxil
CHECK_INTERVAL -> CheckInterval
a0a614c
@thraxil
GLOBAL_THROTTLE -> GlobalThrottle
956b06d
@thraxil
LAST_ERROR_EMAIL -> LastErrorEmail
b59c4a4
@thraxil
EMAIL_ON_ERROR -> EmailOnError
6f7af4b
@thraxil
SMTP_SERVER -> SMTPServer
b088cf4
@thraxil
SMTP_PORT -> SMTPPort
836c47e
@thraxil
SMTP_USER -> SMTPUser
7045e8c
@thraxil
SMTP_PASSWORD -> SMTPPassword
68e4d53
@thraxil
WINDOW -> Window
5e612e6
@thraxil
GLOBAL_BACKOFF -> GlobalBackoff
02350d2
@thraxil
EXP_FAILED -> ExpFailed
9d09f57
@thraxil
EXP_PASSED -> ExpPassed
00dd7ac
@thraxil
EXP_ERRORS -> ExpErrors
91d116d
@thraxil
EXP_GLOBAL_THROTTLE -> ExpGlobalThrottle
74af32e
@thraxil
EXP_GLOBAL_BACKOFF -> ExpGlobalBackoff
57f15dd
@thraxil
EXP_UPTIME -> ExpUptime
29b717d
@thraxil
global_throttle -> globalThrottle
1f4df4a
@thraxil
recoveries_sent -> recoveriesSent
c4cd956
@thraxil
don't export SMTPEmailer
9f81779
@thraxil
don't export expvar variables
5b45e34
@thraxil
runbook_link -> runbookLink
24877c7
@thraxil
alerts_sent -> alertsSent
8645b11
@thraxil
raw_response -> rawResponse
5c48e77
@thraxil
backoff_time -> backoffTime
bca927b
@coveralls
Copy link

coveralls commented Jul 29, 2017

Coverage Status

Coverage decreased (-0.6%) to 31.065% when pulling 0e7ff78 on thraxil:golint into 36d4d44 on ccnmtl:master.

@nikolas nikolas merged commit 4967b95 into ccnmtl:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thraxil @coveralls @nikolas