Golint

alert.html

@@ -37,10 +37,10 @@ <h1><a href="/">Hound</a>: <span class="glyphicon {{$element.GlyphIcon}}" aria-h
 </th>
 <td>
 <h2>Daily Graph</h2>
-<img src="{{$element.DailyGraphUrl}}" width="800" height="150" />
+<img src="{{$element.DailyGraphURL}}" width="800" height="150" />
 
 <h2>Weekly Graph</h2>
-<img src="{{$element.WeeklyGraphUrl}}" width="800" height="75" />
+<img src="{{$element.WeeklyGraphURL}}" width="800" height="75" />
 </td></tr>
 
 {{ if $element.RunBookLink }}

alert_test.go

@@ -12,7 +12,7 @@ type DummyFetcher struct{}
 func (d DummyFetcher) Get(url string) (*http.Response, error) { return nil, nil }
 
 func Test_String(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.String() != "OK\tfoo [foo]" {
 		t.Error("wrong value")
 	}
@@ -24,53 +24,53 @@ func Test_String(t *testing.T) {
 }
 
 func Test_StringWhiteSpaceRemoval(t *testing.T) {
-	a := NewAlert("foo", " foo\n\n \t \r", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", " foo\n\n \t \r", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.Metric != "foo" {
 		t.Error("whitespace not removed from metric")
 	}
 }
 
-func Test_Url(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
-	if a.Url() != "?target=keepLastValue(foo)&format=raw&from=-"+WINDOW {
-		t.Error(fmt.Sprintf("wrong value: %s", a.Url()))
+func Test_URL(t *testing.T) {
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	if a.URL() != "?target=keepLastValue(foo)&format=raw&from=-"+window {
+		t.Error(fmt.Sprintf("wrong value: %s", a.URL()))
 	}
 }
 
-func Test_DailyGraphUrl(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
-	if a.DailyGraphUrl() != "?target=foo&target=threshold(10.000000)&width=800&height=150&bgcolor=FFFFFF&fgcolor=000000&hideGrid=true&colorList=%23999999,%23006699&from=-24hours" {
-		t.Error(fmt.Sprintf("wrong value: %s", a.DailyGraphUrl()))
+func Test_DailyGraphURL(t *testing.T) {
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	if a.DailyGraphURL() != "?target=foo&target=threshold(10.000000)&width=800&height=150&bgcolor=FFFFFF&fgcolor=000000&hideGrid=true&colorList=%23999999,%23006699&from=-24hours" {
+		t.Error(fmt.Sprintf("wrong value: %s", a.DailyGraphURL()))
 	}
 }
 
-func Test_WeeklyGraphUrl(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
-	if a.WeeklyGraphUrl() != "?target=foo&target=threshold(10.000000)&width=800&height=75&hideGrid=true&hideLegend=true&graphOnly=true&hideAxes=true&bgcolor=EEEEEE&fgcolor=000000&hideGrid=true&colorList=%23cccccc,%236699cc&from=-7days" {
-		t.Error(fmt.Sprintf("wrong value: %s", a.WeeklyGraphUrl()))
+func Test_WeeklyGraphURL(t *testing.T) {
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	if a.WeeklyGraphURL() != "?target=foo&target=threshold(10.000000)&width=800&height=75&hideGrid=true&hideLegend=true&graphOnly=true&hideAxes=true&bgcolor=EEEEEE&fgcolor=000000&hideGrid=true&colorList=%23cccccc,%236699cc&from=-7days" {
+		t.Error(fmt.Sprintf("wrong value: %s", a.WeeklyGraphURL()))
 	}
 }
 
 func Test_RecoveryEmailSubject(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.RecoveryEmailSubject() != "[RECOVERED] foo" {
 		t.Error(fmt.Sprintf("wrong value: %s", a.RecoveryEmailSubject()))
 	}
 }
 
 func Test_AlertEmailSubject(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
-	if a.AlertEmailSubject() != "[ALERT] foo" {
-		t.Error(fmt.Sprintf("wrong value: %s", a.AlertEmailSubject()))
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	if a.alertEmailSubject() != "[ALERT] foo" {
+		t.Error(fmt.Sprintf("wrong value: %s", a.alertEmailSubject()))
 	}
 	a.Type = "Notice"
-	if a.AlertEmailSubject() != "[NOTICE] foo" {
-		t.Error(fmt.Sprintf("wrong value: %s", a.AlertEmailSubject()))
+	if a.alertEmailSubject() != "[NOTICE] foo" {
+		t.Error(fmt.Sprintf("wrong value: %s", a.alertEmailSubject()))
 	}
 }
 
 func Test_GlyphIcon(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.GlyphIcon() != "glyphicon-warning-sign" {
 		t.Error(fmt.Sprintf("wrong value: %s", a.GlyphIcon()))
 	}
@@ -80,26 +80,26 @@ func Test_GlyphIcon(t *testing.T) {
 	}
 }
 
-func Test_AlertEmailBody(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
-	if !strings.HasPrefix(a.AlertEmailBody(), "foo [foo] has triggered an alert") {
-		t.Error(fmt.Sprintf("wrong value: %s", a.AlertEmailBody()))
+func Test_alertEmailBody(t *testing.T) {
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	if !strings.HasPrefix(a.alertEmailBody(), "foo [foo] has triggered an alert") {
+		t.Error(fmt.Sprintf("wrong value: %s", a.alertEmailBody()))
 	}
-	a = NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "runbooklinkfoo")
-	if !strings.Contains(a.AlertEmailBody(), "runbooklinkfoo") {
-		t.Error(fmt.Sprintf("wrong value: %s", a.AlertEmailBody()))
+	a = newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "runbooklinkfoo")
+	if !strings.Contains(a.alertEmailBody(), "runbooklinkfoo") {
+		t.Error(fmt.Sprintf("wrong value: %s", a.alertEmailBody()))
 	}
 }
 
 func Test_RecoveryEmailBody(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if !strings.HasPrefix(a.RecoveryEmailBody(), "foo [foo] has returned below 10.000000") {
 		t.Error(fmt.Sprintf("wrong value: %s", a.RecoveryEmailBody()))
 	}
 }
 
 func Test_UpdateState(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	s, rs, e, f, as := a.UpdateState(0)
 	if s != 1 {
 		t.Error("s is wrong")
@@ -176,7 +176,7 @@ func Test_extractLastValue(t *testing.T) {
 }
 
 func Test_UpdateStatus(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	a.UpdateStatus(11.0)
 	if a.Status != "Failed" {
 		t.Error("should've failed")
@@ -197,31 +197,31 @@ func Test_UpdateStatus(t *testing.T) {
 }
 
 func Test_RenderDirection(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.RenderDirection() != "<" {
 		t.Error("(OK, above) expected <, got >")
 	}
 
-	a = NewAlert("foo", "foo", "", 10, "below", DummyFetcher{}, "test@example.com", "")
+	a = newAlert("foo", "foo", "", 10, "below", DummyFetcher{}, "test@example.com", "")
 	if a.RenderDirection() != ">" {
 		t.Error("(OK, below) expected <, got >")
 	}
 
-	a = NewAlert("foo", "foo", "", 10, "below", DummyFetcher{}, "test@example.com", "")
+	a = newAlert("foo", "foo", "", 10, "below", DummyFetcher{}, "test@example.com", "")
 	a.Status = "Failed"
 	if a.RenderDirection() != "<" {
 		t.Error("(Failed, below) expected >, got <")
 	}
 
-	a = NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a = newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	a.Status = "Failed"
 	if a.RenderDirection() != ">" {
 		t.Error("(Failed, above) expected <, got >")
 	}
 }
 
 func Test_BootstrapStatus(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	if a.BootstrapStatus() != "OK" {
 		t.Error("bootstrap status OK expected OK")
 	}
@@ -236,7 +236,7 @@ func Test_BootstrapStatus(t *testing.T) {
 }
 
 func Test_JustRecovered(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	a.PreviousStatus = "Failed"
 	if !a.JustRecovered() {
 		t.Error("JustRecovered expected true")
@@ -252,7 +252,7 @@ func Test_JustRecovered(t *testing.T) {
 }
 
 func Test_Hash(t *testing.T) {
-	a := NewAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
+	a := newAlert("foo", "foo", "", 10, "above", DummyFetcher{}, "test@example.com", "")
 	expected := "22138d2e6b"
 	result := a.Hash()
 	if result != expected {