Close the http.Get() request after opened #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hound sometimes gives errors like these when it's backed up:
I think this can be avoided with the changes here. It's best practice to
close the http.Get() response, and also to use a new instance of
http.Client instead of the http.DefaultClient singleton (used by calls
to http.Get()).
I've given the new http.Client a 2-second timeout, which should be fine,
but we can adjust as needed.