-
Notifications
You must be signed in to change notification settings - Fork 2
FIX run.sh: set alert template explicitely #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FWIW, the |
|
Here is about docker in production: https://thehftguy.com/2016/11/01/docker-in-production-an-history-of-failure/ and https://thehftguy.com/2017/02/23/docker-in-production-an-update/. Some people will still use docker in production, and some people will also never write tests. To each their own. Long story short, run.sh shouldn't be used to run locally, since the program is configured via environment variables, it should be the default way to run your software. |
|
I'm just saying, the intention of the Hound itself is just a single binary file, that takes config from environment variables, so it's easy to run in a container, on Heroku, or started directly from systemd or supervisord or from a shell script or whatever fits one's own environment. |
|
thraxil commented:
I agree. I don't see why it's such a big deal to provide a working shell script, though (and do not forget that simple code like |
|
I have added some documentation for running it with docker, first. I do not pretend for it to be perfect or complete, but since I am not an avid docker user myself, it would be hard for me to do much better. |
Bonus typo fix.
|
With a |
|
I see. That is a valid point. Would you mind using an extra argument, or a different file for the development purpose? Such as |
|
I think what I'm going to do is rename it to |
Minor cosmetic change, for documentation by code mostly. Also, the README.md is corrected about the nohup.