From 1e736c8838bf020b7461e157588ee570a78b761a Mon Sep 17 00:00:00 2001 From: Grant Murphy Date: Wed, 11 Jan 2017 09:51:25 -0800 Subject: [PATCH] Fix test case (invalid sample code) --- rules/hardcoded_credentials_test.go | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/rules/hardcoded_credentials_test.go b/rules/hardcoded_credentials_test.go index 3999d7fe60..966ee10de2 100644 --- a/rules/hardcoded_credentials_test.go +++ b/rules/hardcoded_credentials_test.go @@ -120,11 +120,27 @@ func TestHardcodedConstInteger(t *testing.T) { package main const ( - ATNStateSomethingElse = 1, - ATNStateTokenStart = 42, + ATNStateSomethingElse = 1 + ATNStateTokenStart = 42 ) func main() { println(ATNStateTokenStart) }`, analyzer) checkTestResults(t, issues, 0, "Potential hardcoded credentials") } + +func TestHardcodedConstString(t *testing.T) { + config := map[string]interface{}{"ignoreNosec": false} + analyzer := gas.NewAnalyzer(config, nil) + analyzer.AddRule(NewHardcodedCredentials(config)) + issues := gasTestRunner(` + package main + + const ( + ATNStateTokenStart = "foo bar" + ) + func main() { + println(ATNStateTokenStart) + }`, analyzer) + checkTestResults(t, issues, 1, "Potential hardcoded credentials") +}