From c2c21553a31363ede1236799c29625f60e6b3f15 Mon Sep 17 00:00:00 2001 From: Cosmin Cojocar Date: Wed, 7 Feb 2018 14:07:24 +0100 Subject: [PATCH] Fix some gas warnings --- cmd/gas/main.go | 14 ++++++++++---- testutils/pkg.go | 3 ++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/cmd/gas/main.go b/cmd/gas/main.go index deef06e1b8..80208ea517 100644 --- a/cmd/gas/main.go +++ b/cmd/gas/main.go @@ -149,9 +149,15 @@ func saveOutput(filename, format string, issues []*gas.Issue, metrics *gas.Metri return err } defer outfile.Close() - output.CreateReport(outfile, format, issues, metrics) + err = output.CreateReport(outfile, format, issues, metrics) + if err != nil { + return err + } } else { - output.CreateReport(os.Stdout, format, issues, metrics) + err := output.CreateReport(os.Stdout, format, issues, metrics) + if err != nil { + return err + } } return nil } @@ -166,7 +172,7 @@ func main() { // Ensure at least one file was specified if flag.NArg() == 0 { - fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") + fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") // #nosec flag.Usage() os.Exit(1) } @@ -231,7 +237,7 @@ func main() { } // Finialize logging - logWriter.Close() + logWriter.Close() // #nosec // Do we have an issue? If so exit 1 if issuesFound { diff --git a/testutils/pkg.go b/testutils/pkg.go index 34404e7819..569cd804eb 100644 --- a/testutils/pkg.go +++ b/testutils/pkg.go @@ -128,6 +128,7 @@ func (p *TestPackage) CreateContext(filename string) *gas.Context { // Close will delete the package and all files in that directory func (p *TestPackage) Close() { if p.ondisk { - os.RemoveAll(p.Path) + err := os.RemoveAll(p.Path) + log.Println(err) } }