From 6102c93bc62d36989ff2b4985e8c16ce3d1a337a Mon Sep 17 00:00:00 2001 From: Chris Comeaux Date: Thu, 27 Jan 2022 07:53:41 -0600 Subject: [PATCH 1/4] There was a change just two days ago to the XML API documentation dropping the leading "www" on the API request: boardgamegeek.com/wiki/diff/BGG_XML_API2/2342384/2488801 This is in sync with the time that people started coming here to point out that they were getting errors on the app. I have not tested this change because I don't have the environment setup, but I feel like it might fix it. --- app/src/main/java/com/boardgamegeek/io/Adapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/boardgamegeek/io/Adapter.java b/app/src/main/java/com/boardgamegeek/io/Adapter.java index 6a0e64fcb..c829520e4 100644 --- a/app/src/main/java/com/boardgamegeek/io/Adapter.java +++ b/app/src/main/java/com/boardgamegeek/io/Adapter.java @@ -44,7 +44,7 @@ private static Retrofit.Builder createBuilderWithoutConverterFactory(Context con httpClient = HttpUtils.getHttpClientWithAuth(context); } return new Retrofit.Builder() - .baseUrl("https://www.boardgamegeek.com/") + .baseUrl("https://boardgamegeek.com/") .client(httpClient); } } From a2cb065ca8e46cb9941c1ac589f123f68a7f0aeb Mon Sep 17 00:00:00 2001 From: Chris Comeaux Date: Sat, 29 Jan 2022 22:11:18 -0600 Subject: [PATCH 2/4] Remove the www subdomain from the URL for updates to the collection or plays. --- app/src/main/java/com/boardgamegeek/service/CollectionTask.java | 2 +- app/src/main/java/com/boardgamegeek/service/SyncPlaysUpload.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/boardgamegeek/service/CollectionTask.java b/app/src/main/java/com/boardgamegeek/service/CollectionTask.java index 25d0a5e4d..d38535283 100644 --- a/app/src/main/java/com/boardgamegeek/service/CollectionTask.java +++ b/app/src/main/java/com/boardgamegeek/service/CollectionTask.java @@ -17,7 +17,7 @@ import okhttp3.Response; public abstract class CollectionTask { - private static final String GEEK_COLLECTION_URL = "https://www.boardgamegeek.com/geekcollection.php"; + private static final String GEEK_COLLECTION_URL = "https://boardgamegeek.com/geekcollection.php"; private static final String ERROR_DIV = "
"; private static final String AUTH_ERROR_TEXT = "login"; protected final OkHttpClient client; diff --git a/app/src/main/java/com/boardgamegeek/service/SyncPlaysUpload.kt b/app/src/main/java/com/boardgamegeek/service/SyncPlaysUpload.kt index 596f48d31..e6c796653 100644 --- a/app/src/main/java/com/boardgamegeek/service/SyncPlaysUpload.kt +++ b/app/src/main/java/com/boardgamegeek/service/SyncPlaysUpload.kt @@ -343,7 +343,7 @@ class SyncPlaysUpload(application: BggApplication, service: BggService, syncResu } companion object { - const val GEEK_PLAY_URL = "https://www.boardgamegeek.com/geekplay.php" + const val GEEK_PLAY_URL = "https://boardgamegeek.com/geekplay.php" private fun getMapKey(index: Int, key: String): String { return "players[$index][$key]" From 2e53d113d6e21f6bb2f0745ede6387bda9c28ba7 Mon Sep 17 00:00:00 2001 From: Chris Comeaux Date: Sat, 29 Jan 2022 22:12:48 -0600 Subject: [PATCH 3/4] Don't safe an auth token if the cookie for "bggpassword" is "deleted" --- app/src/main/java/com/boardgamegeek/auth/BggCookieJar.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/boardgamegeek/auth/BggCookieJar.java b/app/src/main/java/com/boardgamegeek/auth/BggCookieJar.java index 96851b19e..56cbb2d54 100644 --- a/app/src/main/java/com/boardgamegeek/auth/BggCookieJar.java +++ b/app/src/main/java/com/boardgamegeek/auth/BggCookieJar.java @@ -21,7 +21,8 @@ public void saveFromResponse(@NonNull HttpUrl url, @NonNull List cookies Timber.w(url.toString()); Timber.w(cookies.toString()); for (Cookie cookie : cookies) { - if ("bggpassword".equalsIgnoreCase(cookie.name())) { + if ("bggpassword".equalsIgnoreCase(cookie.name()) && + !"deleted".equalsIgnoreCase(cookie.value())) { authToken = cookie.value(); authTokenExpiry = cookie.expiresAt(); } From cdaca1cf8b109a89a7ca87e266699ea2f258a474 Mon Sep 17 00:00:00 2001 From: Chris Comeaux Date: Sun, 30 Jan 2022 16:54:03 -0600 Subject: [PATCH 4/4] Update patch number and change log for 6.8.2 --- CHANGELOG.md | 4 ++++ app/build.gradle | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f8b8fc1eb..6659d466b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,10 @@ Release Notes ============= +Version 6.8.2 +------------- +Correct error 307 received when attempting to upload data to BGG + Version 6.8.1 ------------- * Correct problem logging into BGG diff --git a/app/build.gradle b/app/build.gradle index df16de2ff..2838b2566 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -12,7 +12,7 @@ buildscript { def versionMajor = 6 def versionMinor = 8 -def versionPatch = 1 +def versionPatch = 2 def versionBuild = 0 apply plugin: 'com.android.application'