New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVL1 minutes module #1

Merged
merged 3 commits into from Feb 18, 2015

Conversation

Projects
None yet
2 participants
@cooperra

cooperra commented Feb 14, 2015

Added a module that reads sections of the most recent LVL1 minutes.

ccprek added a commit that referenced this pull request Feb 18, 2015

@ccprek ccprek merged commit ff8de4f into ccprek:master Feb 18, 2015

@ccprek

This comment has been minimized.

Show comment
Hide comment
@ccprek

ccprek Feb 24, 2015

Owner

I scaled back the list of command words for the module. It's inevitable that you get false positives on the command words. The longer the list, the more likely this module will be triggered over any competing modules. Will need to try this out in the space to see how it performs. Very cool module!

Owner

ccprek commented Feb 24, 2015

I scaled back the list of command words for the module. It's inevitable that you get false positives on the command words. The longer the list, the more likely this module will be triggered over any competing modules. Will need to try this out in the space to see how it performs. Very cool module!

@cooperra

This comment has been minimized.

Show comment
Hide comment
@cooperra

cooperra Feb 24, 2015

Fair enough. Note that it also asks for confirmation before reading. Some sections can be very long!

cooperra commented Feb 24, 2015

Fair enough. Note that it also asks for confirmation before reading. Some sections can be very long!

@ccprek

This comment has been minimized.

Show comment
Hide comment
@ccprek

ccprek Feb 24, 2015

Owner

Oh yeah, I see that now. Hmm. I'll try playing with the module some tonight to see how it works out and will add in the prompts as needed. Another thing to consider is the 4096 max character limit for the LED display packet, which I haven't yet added a check condition for.

Owner

ccprek commented Feb 24, 2015

Oh yeah, I see that now. Hmm. I'll try playing with the module some tonight to see how it works out and will add in the prompts as needed. Another thing to consider is the 4096 max character limit for the LED display packet, which I haven't yet added a check condition for.

@cooperra cooperra deleted the cooperra:lvl1-minutes branch Jan 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment