New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bithumb Bad Request(Auth Data) - Convert header value to string #1030

Merged
merged 3 commits into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@channprj
Contributor

channprj commented Jan 2, 2018

There's a problem in python code. It occurs Bad Request error because of Api-Sign value. Check below:

ExchangeNotAvailable: bithumb POST https://api.bithumb.com/info/balance 400 Client Error: Bad Request for url: https://api.bithumb.com/info/balance {"status":"5100","message":"Bad Request.(Auth Data)"}

I fixed python code before I read the contributing guide. Some commits will be overwritten automatically, but you can drop it. I checked python code what I fixed, but I can't checked transcompiled python code. Please review my code.

Anyway, I'll add another bithumb API if I have more time.
Thank you for your great project. 馃帀 馃憤

channprj added some commits Jan 2, 2018

@kroitor kroitor self-assigned this Jan 2, 2018

@kroitor

This comment has been minimized.

Member

kroitor commented Jan 2, 2018

Thank you!

@kroitor kroitor merged commit 4bccf8c into ccxt:master Jan 2, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

kroitor added a commit that referenced this pull request Jan 2, 2018

kroitor added a commit that referenced this pull request Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment