Skip to content

Fix: Bithumb Bad Request(Auth Data) - Convert header value to string#1030

Merged
kroitor merged 3 commits into
ccxt:masterfrom
channprj:master
Jan 2, 2018
Merged

Fix: Bithumb Bad Request(Auth Data) - Convert header value to string#1030
kroitor merged 3 commits into
ccxt:masterfrom
channprj:master

Conversation

@channprj

@channprj channprj commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

There's a problem in python code. It occurs Bad Request error because of Api-Sign value. Check below:

ExchangeNotAvailable: bithumb POST https://api.bithumb.com/info/balance 400 Client Error: Bad Request for url: https://api.bithumb.com/info/balance {"status":"5100","message":"Bad Request.(Auth Data)"}

I fixed python code before I read the contributing guide. Some commits will be overwritten automatically, but you can drop it. I checked python code what I fixed, but I can't checked transcompiled python code. Please review my code.

Anyway, I'll add another bithumb API if I have more time.
Thank you for your great project. 🎉 👍

@kroitor kroitor self-assigned this Jan 2, 2018
@kroitor

kroitor commented Jan 2, 2018

Copy link
Copy Markdown
Member

Thank you!

@kroitor kroitor merged commit 4bccf8c into ccxt:master Jan 2, 2018
kroitor added a commit that referenced this pull request Jan 2, 2018
kroitor added a commit that referenced this pull request Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants