Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Bithumb Bad Request(Auth Data) - Convert header value to string #1030
Conversation
channprj
added some commits
Jan 2, 2018
kroitor
self-assigned this
Jan 2, 2018
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
kroitor
merged commit 4bccf8c
into
ccxt:master
Jan 2, 2018
added a commit
that referenced
this pull request
Jan 2, 2018
added a commit
that referenced
this pull request
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
channprj commentedJan 2, 2018
There's a problem in python code. It occurs
Bad Requesterror because ofApi-Signvalue. Check below:I fixed python code before I read the contributing guide. Some commits will be overwritten automatically, but you can drop it. I checked python code what I fixed, but I can't checked transcompiled python code. Please review my code.
Anyway, I'll add another bithumb API if I have more time.🎉 👍
Thank you for your great project.