CJS -> ESM migration :: Ready #12619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosty00
reviewed
Oct 8, 2022
python/package.json
Outdated
| @@ -12,20 +24,20 @@ | |||
| }, | |||
| "repository": { | |||
| "type": "git", | |||
| "url": "https://github.com/ccxt/ccxt.git" | |||
| "url": "https://github.com/carlosmiei/ccxt/tree/esm-migration" | |||
There was a problem hiding this comment.
@frosty00 ofc 😅 I changed it because I needed to publish it to be consumed by ccxt.pro
https://www.npmjs.com/package/ccxt-esm
|
Will this ever be merged? :D |
|
@carlosmiei Thanks for clarifying this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that aims to migrate the current module system (CommonJS) to esm, due to the added benefits of this system (security, tree shaking, ...)
MIgrated components:
Not migrated:
To do: