chore: update ids#992
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the library’s default client order ID prefixes (spot and derivatives) and aligns the static tests to the new expected values, keeping request-generation behavior consistent across the TypeScript implementation and the deprecated JS build.
Changes:
- Updated
SPOT_PREFIXandCONTRACT_PREFIXdefaults in the mainBinanceclass. - Updated static tests (MJS + TS) to assert the new prefixes.
- Updated the same prefixes in the deprecated implementation for consistency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/static-tests.mjs |
Updates expected spot/contract client order ID prefixes in static request-shape tests. |
tests/binance-class-static.test.ts |
Mirrors the same prefix updates in the TypeScript static test suite. |
src/node-binance-api.ts |
Changes the default SPOT_PREFIX / CONTRACT_PREFIX used when generating client order IDs. |
deprecated/node-binance-api.js |
Aligns deprecated JS defaults with the updated prefix values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+87
to
+88
| SPOT_PREFIX = "x-TKT5PX2F"; | ||
| CONTRACT_PREFIX = "x-cvBPrNm9"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.