From 2ce807c9c810eebe358c395eaf1f125f0d69c8ea Mon Sep 17 00:00:00 2001 From: cd2357 Date: Thu, 7 May 2020 14:41:00 +0200 Subject: [PATCH] Upgrade JavaFX to v14 Update the gradle dependency to JavaFX 14. This brings to Bisq the latest JavaFX fixes and improvements, especially in the areas of UI performance, memory management and security. JavaFX can be upgraded independently of the JDK used to build the application, so this change is modular and does not affect other parts of the build process. Related / likely related to: #350 #2135 #2509 #3128 #3307 #3308 #3343 #3430 #3657 #3677 #3683 #3686 #3786 #3787 #3892 #3917 #3918 #3936 --- build.gradle | 2 +- desktop/src/main/java/bisq/desktop/app/BisqAppMain.java | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index be8e7f8b3c2..cc1b3108022 100644 --- a/build.gradle +++ b/build.gradle @@ -47,7 +47,7 @@ configure(subprojects) { httpcoreVersion = '4.4.13' ioVersion = '2.6' jacksonVersion = '2.8.10' - javafxVersion = '11.0.2' + javafxVersion = '14' javaxAnnotationVersion = '1.2' jcsvVersion = '1.4.0' jetbrainsAnnotationsVersion = '13.0' diff --git a/desktop/src/main/java/bisq/desktop/app/BisqAppMain.java b/desktop/src/main/java/bisq/desktop/app/BisqAppMain.java index d02c6e11c65..25053004bae 100644 --- a/desktop/src/main/java/bisq/desktop/app/BisqAppMain.java +++ b/desktop/src/main/java/bisq/desktop/app/BisqAppMain.java @@ -129,5 +129,10 @@ protected void startApplication() { @Override protected void onApplicationStarted() { super.onApplicationStarted(); + + // Relevant to have this in the logs, for support cases + // This can only be called after JavaFX is initialized, otherwise the version logged will be null + // Therefore, calling this as part of onApplicationStarted() + log.info("Using JavaFX {}", System.getProperty("javafx.version")); } }