Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run security recipe in fullstack #185

Merged
merged 2 commits into from Nov 10, 2016
Merged

Conversation

@wolf31o2
Copy link
Contributor

wolf31o2 commented Nov 10, 2016

Previously, we includes the security recipe conditional on the configuration. However, it's also quite valid to have this configuration property be empty, using CDAP's pre-defined default. Instead, always running the security recipe from fullstack, which should always install the full CDAP stack, regardless of configuration, as the default start state on services is stopped.

@wolf31o2 wolf31o2 force-pushed the feature/cleanup-security branch from 4418302 to d07bfb1 Nov 10, 2016
@wolf31o2 wolf31o2 force-pushed the feature/cleanup-security branch from e127803 to 253fa84 Nov 10, 2016
@dereklwood

This comment has been minimized.

Copy link
Collaborator

dereklwood commented Nov 10, 2016

👍 lgtm

@wolf31o2 wolf31o2 merged commit 5ced1ae into master Nov 10, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wolf31o2 wolf31o2 deleted the feature/cleanup-security branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.