Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debug.Pretty.Simple module for pretty debugging #18

Merged
merged 6 commits into from Oct 17, 2017
Merged

Add Debug.Pretty.Simple module for pretty debugging #18

merged 6 commits into from Oct 17, 2017

Conversation

yigitozkavci
Copy link
Contributor

@yigitozkavci yigitozkavci commented Oct 16, 2017

Related issue: #15
Notes:

  • I carried all comments from Debug.Trace module to here. I think it also would present good documentation for readers of this module.

cdepillabout
cdepillabout reviewed Oct 17, 2017
View changes
Copy link
Owner

@cdepillabout cdepillabout left a comment

One small comment in the documentation. Other than that, this looks good.

I'll merge this and make a new release when the problem with the documentation is fixed 👍

src/Debug/Pretty/Simple.hs Outdated
{-# LANGUAGE CPP #-}

{-|
Module : Text.Pretty.Simple.Internal
Copy link
Owner

@cdepillabout cdepillabout Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to Debug.Pretty.Simple?

@cdepillabout
Copy link
Owner

@cdepillabout cdepillabout commented Oct 17, 2017

Closes #15.

@yigitozkavci
Copy link
Contributor Author

@yigitozkavci yigitozkavci commented Oct 17, 2017

Thanks for noticing @cdepillabout, fixed :)

@cdepillabout cdepillabout merged commit 520069b into cdepillabout:master Oct 17, 2017
1 check passed
@cdepillabout
Copy link
Owner

@cdepillabout cdepillabout commented Oct 17, 2017

Thanks! I've released as v2.0.1.0 on hackage.

@cdepillabout cdepillabout mentioned this pull request Oct 17, 2017
Closed
@cdepillabout cdepillabout mentioned this pull request Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yigitozkavci @cdepillabout