Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreground and background colors #111

Merged
merged 1 commit into from Jun 25, 2019
Merged

Conversation

cdepillabout
Copy link
Owner

@cdepillabout cdepillabout commented Jun 25, 2019

This PR fixes the bug in #29 with not being able to set the background color for a terminal if the palette was set.

In #110, @dakotaclemenceplaza figured out that this was caused by not setting any value for the alpha channel of an RGBA color.

This PR uses the fix from #110 and simplifies some of the logic for setting colors.

Fixes #29

@cdepillabout
Copy link
Owner Author

cdepillabout commented Jun 25, 2019

@dakotaclemenceplaza Could you try this out on your machine and make sure you're still able to set the foreground and background colors properly?

I just want to make sure this PR is working as well as you have #110 working.

@dakotaclemenceplaza
Copy link
Contributor

dakotaclemenceplaza commented Jun 25, 2019

@cdepillabout Everything works as expected.

@cdepillabout cdepillabout merged commit 3776e63 into master Jun 25, 2019
@cdepillabout cdepillabout deleted the background-color-stuff branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't set background color for terminal
2 participants