Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on GHC 8.10 #8

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

ocharles
Copy link
Contributor

I believe these changes are also compatible with older GHCs.

Fixes #7

@cdepillabout
Copy link
Owner

As far as I can tell, this no longer builds on GHC-8.2 or older:

https://travis-ci.org/github/cdepillabout/world-peace/builds/699619671

I'll just disable those builds on CI, and if someone wants support for older GHCs, I'd accept a PR getting that working.

@cdepillabout cdepillabout reopened this Jun 24, 2020
@cdepillabout cdepillabout merged commit 03c2980 into cdepillabout:master Jun 24, 2020
@cdepillabout
Copy link
Owner

@ocharles Are you guys using world-peace? I depend on it in servant-checked-exceptions, but I wasn't aware of anyone directly using it.

@ocharles
Copy link
Contributor Author

@cdepillabout yea, we also use that library (GHC 8.8 and above)

@cdepillabout
Copy link
Owner

@ocharles Oh, nice.

Well if there are any features you guys need, please feel free to open up issues or PRs.

I've basically added everything I needed for servant-checked-exceptions, but I'm not actively working on adding stuff to this library.

Also, if world-peace ever becomes a bottleneck for you, you may be interested in switching to a library that has had more optimizations done.

@ocharles
Copy link
Contributor Author

Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile on GHC 8.10
2 participants