Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support YQL, Remove Webservice because it is no longer supported by Yahoo #4

Merged
merged 22 commits into from Oct 11, 2016
Merged

Support YQL, Remove Webservice because it is no longer supported by Yahoo #4

merged 22 commits into from Oct 11, 2016

Conversation

mchaver
Copy link
Collaborator

@mchaver mchaver commented Oct 9, 2016

No description provided.

mchaver and others added 15 commits October 8, 2016 23:09
@mchaver
Working functions, types and API for YQL
85c0219
@mchaver
Start reorganizing the code
1af5d91
@mchaver
Split into internal files
2b8c90a
@mchaver
servant-0.4 is compiled
a661a64
@mchaver
Compiles with servant 0.4-0.9
af3ff3f
@mchaver
Remove webserver api (no longer provided by Yahoo)
78cca2d
@mchaver
API test passing for all versions of servant
674f44a
@mchaver
Parsers null returns for non-existent StockSymbols as Nothing
006ebe0
@mchaver
Clean up documentation and tests
412b441
@mchaver
Merge pull request #1 from mchaver/yql
ceb465c 
Update package to query yql, remove deprecated webservice
@cdepillabout
Remove whitespace on ends of lines in README.md
b4d7fca
@cdepillabout
Add additional shields and show required imports in example.
fc766a3
@cdepillabout
Fix some whitespace on ends of lines and rearrange some documentation.
91fff28
@cdepillabout
Rename Web.Yahoo.Finance.YQL.Types module to Web.Yahoo.Finance.YQL.
3984d93
@cdepillabout
Remove whitespaces at end of lines in FinanceSpec.
20b9c76
@cdepillabout
Copy link
Owner

@mchaver Thanks a lot!

I've added you as a collaborator for this project. Feel free to merge this PR in. Also, if you tell me your hackage username I'll add you as an admin for the package on hackage. That way you'll be able to do releases to hackage.

In 3984d93 I renamed the Web.Yahoo.Finance.YQL.Types module to Web.Yahoo.Finance.YQL. I think this makes more sense, given that the module is also exporting the functions for actually getting stock quotes. What doyou think?

Also, it appears that the tests are failing on travis-ci. I'm not sure why this is. Do you have any ideas? If we can't figure it out, I guess we can just disable the tests on travis-ci.

@mchaver
Copy link
Collaborator Author

mchaver commented Oct 10, 2016

@cdepillabout
Yeah, the rename makes sense.

My guess would be the network settings on the travis system that runs the tests. On travis the tests only pass on #GHC 7.1.3. I can get the tests stack test to pass on mac and ubuntu. I think it is fine to disable the travis tests and just make sure stack test works before pushing to hackage.

@cdepillabout
Don't run test in travis.
7b16818
@cdepillabout
Update .travis.yml file.
28e271a 
Update the .travis.yml file with the recommended file from
https://docs.haskellstack.org/en/stable/GUIDE/#travis-with-caching.

Also enable additional travis targets (older versions of ghc).
@cdepillabout
Disable 7.6.3 and stack-default builds in .travis.yml.
5ab50a4
@cdepillabout
Create stack-servant-0.9.yaml file.
e00775a 
This commit creates a stack-servant-0.9.yaml file.  This is used by the
test-stack-files.sh script to test that yahoo-finance-api works with
servant-0.9.

This commit also sets stack.yaml to just be a normal build using lts-7.
@cdepillabout
Import Control.Applicative when using old version of base.
fe397bc
@cdepillabout
Disable tests in .travis.yml when building with cabal.
b8f7bf1
@cdepillabout
Disable lts-2 builds in .travis.yml because servant version is too old.
69d0ac6
@cdepillabout cdepillabout merged commit a80ae06 into cdepillabout:master Oct 11, 2016
@cdepillabout
Copy link
Owner

I released v0.2.0.0 to hackage. Thanks again!

Closes #3.

@cdepillabout cdepillabout mentioned this pull request Oct 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mchaver @cdepillabout