Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support YQL, Remove Webservice because it is no longer supported by Yahoo #4

Merged
merged 22 commits into from Oct 11, 2016
Merged

Conversation

@mchaver
Copy link
Collaborator

@mchaver mchaver commented Oct 9, 2016

No description provided.

@cdepillabout
Copy link
Owner

@cdepillabout cdepillabout commented Oct 10, 2016

@mchaver Thanks a lot!

I've added you as a collaborator for this project. Feel free to merge this PR in. Also, if you tell me your hackage username I'll add you as an admin for the package on hackage. That way you'll be able to do releases to hackage.

In 3984d93 I renamed the Web.Yahoo.Finance.YQL.Types module to Web.Yahoo.Finance.YQL. I think this makes more sense, given that the module is also exporting the functions for actually getting stock quotes. What doyou think?

Also, it appears that the tests are failing on travis-ci. I'm not sure why this is. Do you have any ideas? If we can't figure it out, I guess we can just disable the tests on travis-ci.

@mchaver
Copy link
Collaborator Author

@mchaver mchaver commented Oct 10, 2016

@cdepillabout
Yeah, the rename makes sense.

My guess would be the network settings on the travis system that runs the tests. On travis the tests only pass on #GHC 7.1.3. I can get the tests stack test to pass on mac and ubuntu. I think it is fine to disable the travis tests and just make sure stack test works before pushing to hackage.

Update the .travis.yml file with the recommended file from
https://docs.haskellstack.org/en/stable/GUIDE/#travis-with-caching.

Also enable additional travis targets (older versions of ghc).
This commit creates a stack-servant-0.9.yaml file.  This is used by the
test-stack-files.sh script to test that yahoo-finance-api works with
servant-0.9.

This commit also sets stack.yaml to just be a normal build using lts-7.
@cdepillabout cdepillabout merged commit a80ae06 into cdepillabout:master Oct 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdepillabout
Copy link
Owner

@cdepillabout cdepillabout commented Oct 11, 2016

I released v0.2.0.0 to hackage. Thanks again!

Closes #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants