Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add Bookmark with special characters in title or very long titles #250

Open
r7l opened this issue Apr 17, 2019 · 3 comments
Open
Assignees

Comments

@r7l
Copy link

r7l commented Apr 17, 2019

Hello,

i've tried to add this site to my bookmarks: https://github.com/vuejs/awesome-vue and it crashed the database because of that fancy icon they have in their title.

A DATABASE ERROR OCCURRED
Error Number: 1366

Incorrect string value: '\xF0\x9F\x8E\x89 A...' for column `unmark`.`marks`.`title` at row 1

INSERT INTO `marks` (`title`, `url`, `created_on`, `url_key`) VALUES ('GitHub - vuejs/awesome-vue: 🎉 A curated list of awesome things related to Vue.js', 'https://github.com/vuejs/awesome-vue', '2019-04-17 18:57:25', '0164d84940f9b41c691a1851f8b742c0')

Filename: models/Marks_model.php

Line Number: 47
@r7l
Copy link
Author

r7l commented Apr 17, 2019

Just found a site with a very long title. Runs into the same issue: https://github.com/Kickball/awesome-selfhosted

A DATABASE ERROR OCCURRED
Error Number: 1406

Data too long for column 'title' at row 1

INSERT INTO `marks` (`title`, `url`, `created_on`, `url_key`) VALUES ('Kickball/awesome-selfhosted: This is a list of Free Software network services and web applications which can be hosted locally. Selfhosting is the process of locally hosting and managing applications instead of renting from SaaS providers.', 'https://github.com/Kickball/awesome-selfhosted', '2019-04-17 21:03:24', '8baf0bca48b6bacdcc4e1fa581a6522f')

Filename: models/Marks_model.php

Line Number: 47

Maybe it would help if it would be possible to edit everything prior of saving it to the DB. I can't add both sites. Whatever i tried to do.

@r7l r7l changed the title Unable to add Bookmark with special characters in title Unable to add Bookmark with special characters in title or very long titles Apr 17, 2019
@cdevroe
Copy link
Owner

cdevroe commented Apr 18, 2019

@r7l Thank you for reporting this issue. The very long titles one is a known issue #184. Both of these issues would be solved by adding a new migration (meaning, a change to the database). We've tried to keep those changes to a minimum in the latest few releases but will need to make them soon.

Perhaps we'll include these fixes in 2.0. I'll keep this issue updated if we can squeeze it in. We'd like this fixed as much as anyone!

@r7l
Copy link
Author

r7l commented Apr 22, 2019

Thanks! I've did a fresh install of Unmark and was running into it. I'll check back once i'll see a 2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants