Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr for extmap handling in bundle #32

Merged
merged 2 commits into from Mar 31, 2017

Conversation

Projects
None yet
4 participants
@suhasHere
Copy link
Contributor

suhasHere commented Mar 30, 2017

No description provided.

@taylor-b
Copy link

taylor-b left a comment

This looks right to me.

@@ -1421,6 +1421,12 @@ SDP Answer
</t>
</section>

<section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default">
<t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this
specification, the identifier used for a given extension MUST identify the the same

This comment has been minimized.

@taylor-b

taylor-b Mar 30, 2017

typo: "the the same"

<section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default">
<t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this
specification, the identifier used for a given extension MUST identify the the same
extension across all the bundled media descriptions. </t>

This comment has been minimized.

@taylor-b

taylor-b Mar 30, 2017

I'd say "all media descriptions in the same BUNDLE group", since technically there may be multiple BUNDLE groups, and they could use different identifier spaces.

@@ -1421,6 +1421,12 @@ SDP Answer
</t>
</section>

<section title="RTP Header Extensions Consideration" anchor="sec-extmap" toc="default">
<t>When <xref target="RFC5285"/> RTP header extensions are used in the context of this
specification, the identifier used for a given extension MUST identify the the same

This comment has been minimized.

@taylor-b

taylor-b Mar 30, 2017

It may be useful to mention "extmap" by name, to make it easy to find if someone searches for it. Could say "the identifier used for a given extension in an 'a=extmap' attribute MUST..."

@ibc

This comment has been minimized.

Copy link

ibc commented Mar 31, 2017

LGTM. In practice existing implementations already do that, but it's better having it as a requirement in the spec.

@cdh4u cdh4u merged commit b2a3369 into cdh4u:master Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.