Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text added, describing the usage of media specific attributes. #33

Merged
merged 5 commits into from Apr 12, 2017

Conversation

Projects
None yet
3 participants
@cdh4u
Copy link
Owner

cdh4u commented Mar 31, 2017

No description provided.

@taylor-b
Copy link

taylor-b left a comment

LGTM

only apply to "m=" lines describing RTP-based media. However, as described in
<xref target="sec-sdp-oa-cat" />, IDENTICAL and TRANSPORT mux category SDP attributes
<xref target="I-D.ietf-mmusic-sdp-mux-attributes" /> are only
associated with the "m=" line associated with the BUNDLE-tag, it means that

This comment has been minimized.

@taylor-b

taylor-b Mar 31, 2017

Just a grammatical thing: "which means" instead of "it means"

This comment has been minimized.

@martinthomson

martinthomson Apr 1, 2017

Contributor

or ". That means"

This comment has been minimized.

@cdh4u

cdh4u Apr 1, 2017

Author Owner

I can do "that means".

<xref target="sec-sdp-oa-cat" />, IDENTICAL and TRANSPORT mux category SDP attributes
<xref target="I-D.ietf-mmusic-sdp-mux-attributes" /> are only
associated with the "m=" line associated with the BUNDLE-tag, it means that
media specific attributes might be associated with an "m=" line describing

This comment has been minimized.

@martinthomson

martinthomson Apr 1, 2017

Contributor

s/might/can

This comment has been minimized.

@cdh4u

cdh4u Apr 1, 2017

Author Owner

Will fix.

@martinthomson
Copy link
Contributor

martinthomson left a comment

I gave up half way here, but the gist of this is right.

I am concerned at the extent of the changes. There seems to be a lot of repetition.

bundle-only "m=" line) associated with a shared address, IDENTICAL and TRANSPORT
mux category SDP attributes <xref target="I-D.ietf-mmusic-sdp-mux-attributes" />
are associated with the "m=" line only if the "m=" line is also associated with
the offerer BUNDLE-tag. Otherwise the offerer MUST NOT associated such SDP attributes

This comment has been minimized.

@martinthomson

martinthomson Apr 12, 2017

Contributor

associate

This comment has been minimized.

@cdh4u

cdh4u Apr 12, 2017

Author Owner

Fixed.

I will also combine the offerer- and answerer paragraphs into a single paragraph, in oder to get rid of some of the repetition you mentioned.

only apply to "m=" lines describing RTP-based media. However, as described in
<xref target="sec-sdp-oa-cat" />, there are cases where IDENTICAL and TRANSPORT
mux category SDP attributes are only associated with the "m=" line associated with
the BUNDLE-tag. That means that media specific IDENTICAL and TRANSPORT mux category

This comment has been minimized.

@martinthomson

martinthomson Apr 12, 2017

Contributor

media-specific

This comment has been minimized.

@cdh4u

cdh4u Apr 12, 2017

Author Owner

Fixed.

<xref format="default" pageno="false" target="I-D.ietf-mmusic-mux-exclusive"/>
with each RTP-based bundle-only "m=" line, and MAY associated an SDP
'rtcp-mux-only' attribute with other bundled RTP-based "m=" lines.
When an offerer generates an initial offer, if the offer contain

This comment has been minimized.

@martinthomson

martinthomson Apr 12, 2017

Contributor

contains

This comment has been minimized.

@cdh4u

cdh4u Apr 12, 2017

Author Owner

Fixed.

When an offerer generates an initial offer, if the offer contain
one or more RTP-based bundled "m=" lines (or, if there is a chance that RTP-based
"m=" lines will later be added to the BUNDLE group), the offerer MUST
associated an SDP 'rtcp-mux' attribute <xref format="default"

This comment has been minimized.

@martinthomson

martinthomson Apr 12, 2017

Contributor

associate

This comment has been minimized.

@cdh4u

cdh4u Apr 12, 2017

Author Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.