Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFIDF doesn't work #21

Open
mmorells opened this issue Jan 17, 2020 · 1 comment
Open

TFIDF doesn't work #21

mmorells opened this issue Jan 17, 2020 · 1 comment

Comments

@mmorells
Copy link

TFIDF doesn't work unless we actually save the DocsSeen value in the Bayes model.

Currently the struct for Word doesn't do this.

type Word struct { Count []uint64 Seen uint64 DocsSeen uint64 json:"-" }

Should be:

type Word struct { Count []uint64 Seen uint64 DocsSeen uint64 }
@mmorells mmorells changed the title TFIDF TFIDF doesn't work Jan 17, 2020
@hepeichun
Copy link

https://github.com/cdipaolo/goml/blob/master/text/tfidf_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hepeichun @mmorells