Corrected typo in DynamicFactory javadoc and made the interfaces static

cdk · Dec 13, 2012 · b314703 · b314703
1 parent 4c0bcd1
commit b314703
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/org/openscience/cdk/DynamicFactory.java b/src/main/org/openscience/cdk/DynamicFactory.java
@@ -604,7 +604,7 @@ private <T> Creator<T> get(ConstructorKey key) {
 
 
     /**
-     * Find a constructor those parameters are assignable from the provided
+     * Find a constructor whose parameters are assignable from the provided
      * key.
      *
      * @param key a key to find the constructor for
@@ -1094,7 +1094,7 @@ public Class<?>[] getInterfaces(Class<?> c) {
      * implements. This interface is constructor injectable allowing us to test
      * the registration using this method.
      */
-    public interface InterfaceProvider {
+    public static interface InterfaceProvider {
 
         /**
          * Access the interfaces for a given class
@@ -1111,7 +1111,7 @@ public interface InterfaceProvider {
      *
      * @param <T>
      */
-    public interface CreationModifier<T> {
+    public static interface CreationModifier<T> {
         public void modify(T instance);
     }
 
@@ -1166,7 +1166,7 @@ public Class<T> getDeclaringClass() {
      *
      * @param <T> the type of object that will be created
      */
-    public interface Creator<T> {
+    public static interface Creator<T> {
 
         /**
          * Create a new instance with the provided object parameters.

diff --git a/src/test/org/openscience/cdk/DynamicFactoryTest.java b/src/test/org/openscience/cdk/DynamicFactoryTest.java
@@ -183,7 +183,7 @@ public void testRegister_Constructor_Modifier() throws Exception {
                                     DynamicFactoryTestMock.class.getConstructor(String.class),
                                     modifier));
 
-        assertNotNull(factory.ofClass(ICDKObject.class));
+        assertNotNull(factory.ofClass(ICDKObject.class, "empty"));
 
 
         // verify the modifier was invoked once