New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF#35302333: fix for CML problem by John May #23

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rwst
Contributor

rwst commented Jun 8, 2012

two simple one-liners, no repercussions

@egonw

This comment has been minimized.

Member

egonw commented Jun 13, 2012

Mmmm... Ralf, this patch changed the authorship and commit message...

It's better to keep the original author, and just "sign it off"...

  1. apply the patch
  2. git commit --amend --signoff

I'll apply John's own version. Actually, if patches are in the patch tracker, a pull is not needed anyway.

@egonw egonw closed this Jun 13, 2012

@rwst

This comment has been minimized.

Contributor

rwst commented Jun 14, 2012

On Wed, Jun 13, 2012 at 03:24:36PM -0700, Egon Willighagen wrote:

Mmmm... Ralf, this patch changed the authorship and commit message...

It's better to keep the original author, and just "sign it off"...

  1. apply the patch
  2. git commit --amend --signoff

I'll apply John's own version. Actually, if patches are in the patch tracker, a pull is not needed anyway.

Good to know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment