Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Patch/runtimeexception #324

Merged
merged 2 commits into from May 20, 2017

Conversation

Projects
None yet
2 participants
Owner

johnmay commented May 20, 2017

Reverts a patch from the other week. Whilst valid, there are some areas that currently use CDKException for control flow (i.e. the caller needs to know to expect and exception). This is bad in general but switching to a RuntimeException means the IDE won't give a hint.

The NoSuchAtomException is converted to a RuntimeException - technically an API break but should be safe-ish. The exception is thrown for programmer error (accessing an atom that doesn't exisit).

johnmay added some commits May 20, 2017

@egonw egonw merged commit 794419e into master May 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@johnmay johnmay deleted the patch/runtimeexception branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment