Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

This commit puts a simple period at the end of sentence 'Method assigns ... #8

Closed
wants to merge 1 commit into from

3 participants

rwst Egon Willighagen Daniel Szisz
Deleted user

...3Dcoordinates...' at the JavaDoc of

placeAliphaticHeavyChain() method.

Daniel Szisz danielszisz This commit puts a simple period at the end of sentence 'Method assig…
…ns 3Dcoordinates...' at the JavaDoc of

placeAliphaticHeavyChain() method.
8425ecd
rwst
rwst commented

This only fixes a typo, like the previous

Egon Willighagen
Owner
egonw commented

Applied and pushed to master.

Daniel, can you perhaps put multiple of such patches in one branch, and then send a pull request on the full branch? A patch up for review does not have to be only one commit...

Egon Willighagen egonw closed this
rwst
rwst commented
Egon Willighagen
Owner
egonw commented

Actually, I haven't... I need to catch up with that soon too...

The good news is, over the summer holidays I want to finish up a Amazon-releasable copy of my Groovy Cheminformatics books, and want to put in much more JCP stuff... so I will catch up... the education season is almost over...

rwst
rwst commented

OK when you're ready for the JCP bugfixes, I'll have a unit test for each, too.

Egon Willighagen
Owner
egonw commented

A list of patches to review is best... the more clearly you communicate, the easier I can do it quickly in between other work... you had a branch somewhere not?

rwst
rwst commented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 02, 2012
Daniel Szisz danielszisz This commit puts a simple period at the end of sentence 'Method assig…
…ns 3Dcoordinates...' at the JavaDoc of

placeAliphaticHeavyChain() method.
8425ecd
This page is out of date. Refresh to see the latest.
2  src/main/org/openscience/cdk/modeling/builder3d/AtomPlacer3D.java
@@ -110,7 +110,7 @@ public IAtomContainer markPlaced(IAtomContainer ac) {
110 110
111 111
112 112 /**
113   - * Method assigns 3Dcoordinates to the heavy atoms in an aliphatic chain
  113 + * Method assigns 3Dcoordinates to the heavy atoms in an aliphatic chain.
114 114 *
115 115 * @param chain the atoms to be assigned, must be connected
116 116 */

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.