Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag-icon-css not automatically updated #13270

Closed
holtkamp opened this issue Feb 26, 2019 · 5 comments
Closed

flag-icon-css not automatically updated #13270

holtkamp opened this issue Feb 26, 2019 · 5 comments

Comments

@holtkamp
Copy link
Contributor

Also see lipis/flag-icons#535


flag-icon-css is configured to automatically update with https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/flag-icon-css/package.json

Version 3.3.0 has been tagged a day ago, but seems not detected by the CDNJS bot, resulting in a 404 page for:

https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.3.0/css/flag-icon.min.css

The last version 3.2.1 seem to have been authored by the @PeterBot but committed by @PeterDaveHello, so the automation seems not 100%...

https://github.com/cdnjs/cdnjs/search?q=flag-icon-css&type=Commits

@PeterDaveHello
Copy link
Contributor

@holtkamp the only reason I'm the committer would be caused by rebasing branch, that's not a common case, usually triggered by bot hanging events with inconsistent commit status, for example:
The bot committed 10 commits but hangs on the server for a while, during that period, some commits are merged on GitHub, that when I step in, I'll rebase the local branch, otherwise, it's 100% automatically.

@PeterDaveHello
Copy link
Contributor

@holtkamp v3.3.0 was not added not becaused it's not detected, on the other hand, it's detected with different file/driectory structure. which needs a manual step in to confirm everything is good, we host more than 3k libraries, with different situations, sometimes the changes are not expected, the bot only commit a version if the structure wasn't change.

@PeterDaveHello
Copy link
Contributor

@holtkamp in this case, two new files detected:

  • ./flags/1x1/xk.svg
  • ./flags/4x3/xk.svg

@holtkamp
Copy link
Contributor Author

ok, thanks for the swift reaction.

#13270 (comment)

Understood, please do not get me wrong: I did not want to offend anybody and got big respect for CDNJS...

#13270 (comment)

mmm, yeah, every time a new flag is added, that would result in new files... Maybe we can make the bot aware of this possibility?

@PeterDaveHello
Copy link
Contributor

No worries at all.
I think it's really not possible to make a bot handle it, even a human takes time to confirm the changes, unless we have AI or ML bot, I don't know a way to do so, especially we don't have the resource to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants