strange file/directory structure in jquery-ui 1.10.3 #2798

Open
PeterDaveHello opened this Issue Mar 10, 2014 · 10 comments

Projects

None yet

5 participants

@PeterDaveHello
Member

Hi,
I found that there is a very strange status in css/base/ and its hard to fix, it was a mix with part of minified files, and there is a minified directory ... don't know how to help ...

@PeterDaveHello
Member

I will respectfully suggest to move out the css file from directory 'minified', by the way, the images under both of css and minified are duplicate.

@hebbet
hebbet commented Mar 12, 2014

maybe you can create an PR (Pull Request), if it looks OK, it might be merged.

@PeterDaveHello
Member

Yeah, but we must know the implications of doing so, that's what I couldn't do.

@PeterDaveHello
Member

Let's tag @petecooper for some comments, thanks!

@petecooper

Yeah, that is strange - if there are deletions to make, that is not ideal. There is no current solution or workaround to deal with deleted files with symlinks etc, so some caution is needed.

There will likely be sites using 1.10.3 as it's currently latest-version-minus-one, though it's perhaps fair to say that more people will be using the more-recent 1.10.4. This is gut feeling on my part, I can't check access logs for statistics.

It looks like @drewfreyling handled the initial commit here d2849a1 - I recommend we wait for comments from him before any action is decided and/or taken.

@PeterDaveHello
Member

Seems no response, I think the maintainers can decide how to fix it, right?

@drewfreyling
Collaborator

I'll take a look.

@drewfreyling
Collaborator

@PeterDaveHello What is the issue exactly? Looks like this is how the zip file is structured? https://jqueryui.com/resources/download/jquery-ui-1.10.3.zip

@PeterDaveHello
Member

Hi @drewfreyling , sorry that I forgot this ticket, originally, I mean there is jquery.ui.base.min.css and jquery.ui.all.min.css, which was minified but not been put in minified, but I didn't notice that is the origin structure of jqueryui, my fault.

Another thing is, the css folder, official name is theme, because there may be not only css files, like base theme, there were some images, will you consider to correct the name of it?

Thanks!

@PeterDaveHello
Member

jquery.tablesorter also has a similar situation

@PeterDaveHello PeterDaveHello changed the title from strange file/dictionary structure in jquery-ui 1.10.3 to strange file/directory structure in jquery-ui 1.10.3 Jun 29, 2014
@Amomo Amomo self-assigned this Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment