Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] [author] Add rsuite@3.0.0-alpha w/ npm auto-update #12713

Closed
wants to merge 0 commits into from

Conversation

@hiyangguo
Copy link
Contributor

commented Apr 18, 2018

Pull request for issue: #12712
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

  • Git repository (required): rsuite/rsuite
  • Official website (optional, not the repository): http://rsuitejs.com/
  • NPM package url (optional): npmjs.com/package/rsuite
  • License and its reference:MIT
  • GitHub / Bitbucket popularity (required):
    • Count of watchers: 16
    • Count of stars: 244
    • Count of forks: 40
  • NPM download stats (optional):
    • Downloads in the last day:
    • Downloads in the last week: 30
    • Downloads in the last month: 306

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.
  • Pull request is sent from a non-master branch with a meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@hiyangguo hiyangguo force-pushed the rsuite:rsuite branch 4 times, most recently Apr 19, 2018

@PeterBot
Copy link
Member

left a comment

@hiyangguo congratulations! a30861a CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/19817, thank you 😀

@hiyangguo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2018

Hi,@PeterDaveHello @sufuf3 :
Thank you so much for providing such good cdn for our open source project.I really hope our lib can use it. And I have passed the robot test. Can you help me reviewer?

@PeterDaveHello

This comment has been minimized.

Copy link
Member

commented Apr 20, 2018

@hiyangguo sure, we'll take a look soon, already in queue!

@hiyangguo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2018

@PeterDaveHello Thank you very much.😄

@hiyangguo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

@PeterDaveHello A week has passed. Can you help me to look at it? Tank you ,very much.

@PeterDaveHello

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

@hiyangguo we'll take a look ASAP, thank you.

@PeterDaveHello PeterDaveHello requested review from sufuf3 and extend1994 Apr 27, 2018

ajax/libs/rsuite/package.json Outdated
{
"name": "rsuite",
"filename": "rsuite.min.js",
"version": "3.0.0-alpha",

This comment has been minimized.

Copy link
@PeterDaveHello

PeterDaveHello Apr 27, 2018

Member

I see no 3.0.0-alpha version on npmjs, maybe just update to the latest v3.0.1?

@hiyangguo hiyangguo force-pushed the rsuite:rsuite branch Apr 27, 2018

@PeterBot
Copy link
Member

left a comment

Oops 😨 8678b63 CI test failed ❗️

@hiyangguo please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/20086 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@hiyangguo hiyangguo closed this Apr 27, 2018

@hiyangguo hiyangguo force-pushed the rsuite:rsuite branch to af478ea Apr 27, 2018

@hiyangguo hiyangguo referenced this pull request Apr 27, 2018
17 of 19 tasks complete
@hiyangguo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

@PeterDaveHello I updated the version to 3.0.1,but I don't know why the pull request was closed , so I Resubmit the pull request #12738 . Can you help me to look at it agian ? Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.