Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[author] add inputmask lib #13242
Conversation
PeterBot
requested review from
dakshshah96
,
extend1994
,
sashberd
and
sufuf3
Feb 5, 2019
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25692 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25694 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25695 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25697 for details |
This comment has been minimized.
This comment has been minimized.
Can you point me in the right direction to fix the ci build? I'm missing something in the package.json. |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25700 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25701 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25702 for details |
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25703 for details |
This comment has been minimized.
This comment has been minimized.
@sufuf3 , @extend1994 , #13126 Versions on npm continue under inputmask. |
PeterDaveHello
reviewed
Feb 5, 2019
ajax/libs/inputmask/package.json Outdated
PeterDaveHello
reviewed
Feb 5, 2019
ajax/libs/inputmask/package.json Outdated
PeterDaveHello
reviewed
Feb 5, 2019
ajax/libs/inputmask/package.json Outdated
PeterDaveHello
reviewed
Feb 5, 2019
ajax/libs/inputmask/package.json Outdated
PeterBot
requested changes
Feb 5, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25708 for details |
This comment has been minimized.
This comment has been minimized.
Let me help squash and rebase commits first. |
This comment has been minimized.
This comment has been minimized.
It's weird that the first commit fb699ac has no author name ... which makes the reabse keep failing:
I'll do another further manualy fix for it, @RobinHerbots you may want to check your git ocnfigs ;) |
PeterDaveHello
force-pushed the
RobinHerbots:Inputmask
branch
from
c0592ee
to
e962d75
Feb 6, 2019
wafflebot
bot
assigned
PeterDaveHello
Feb 6, 2019
wafflebot
bot
added
the
in progress
label
Feb 6, 2019
PeterBot
requested changes
Feb 6, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25726 for details |
This comment has been minimized.
This comment has been minimized.
I did the commit from WSL on my work laptop, ... git wasn't really configured ;-) |
PeterBot
requested changes
Feb 6, 2019
Oops @RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25726 for details |
This comment has been minimized.
This comment has been minimized.
@RobinHerbots got it! Would you mind to fix this one?
|
PeterBot
approved these changes
Feb 6, 2019
@RobinHerbots congratulations! ed74c8e CI test passed! For the details |
This comment has been minimized.
This comment has been minimized.
Ok, done! |
RobinHerbots commentedFeb 5, 2019
Pull request template for new library
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist