New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[author] add inputmask lib #13242

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@RobinHerbots
Copy link

RobinHerbots commented Feb 5, 2019

Pull request template for new library

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.

@PeterBot PeterBot requested review from dakshshah96 , extend1994 , sashberd and sufuf3 Feb 5, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 fb699ac CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25692 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 28ea3b3 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25694 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 10c6028 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25695 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 7491f05 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25697 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@RobinHerbots

This comment has been minimized.

Copy link
Author

RobinHerbots commented Feb 5, 2019

@dakshshah96 ,

Can you point me in the right direction to fix the ci build? I'm missing something in the package.json.

@RobinHerbots RobinHerbots referenced this pull request Feb 5, 2019

Open

CDNJS out of date #2059

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 37a27a1 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25700 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 8723d02 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25701 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 940c07c CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25702 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 2529b6b CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25703 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@RobinHerbots

This comment has been minimized.

Copy link
Author

RobinHerbots commented Feb 5, 2019

@sufuf3 , @extend1994 ,

#13126
The name of the jquery.inputmask has changed to inputmask

Versions on npm continue under inputmask.
Latest jquery.inputmask => 3.3.4
Latest inputmask => 4.0.6

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 c0592ee CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25708 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

Let me help squash and rebase commits first.

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

It's weird that the first commit fb699ac has no author name ... which makes the reabse keep failing:

fatal: empty ident name (for <robin@LAPTOP214.Reynaers.org>) not allowed

I'll do another further manualy fix for it, @RobinHerbots you may want to check your git ocnfigs ;)

@PeterDaveHello PeterDaveHello force-pushed the RobinHerbots:Inputmask branch from c0592ee to e962d75 Feb 6, 2019

@wafflebot wafflebot bot added the in progress label Feb 6, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 e962d75 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25726 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@RobinHerbots

This comment has been minimized.

Copy link
Author

RobinHerbots commented Feb 6, 2019

It's weird that the first commit fb699ac has no author name ... which makes the reabse keep failing:

fatal: empty ident name (for <robin@LAPTOP214.Reynaers.org>) not allowed

I'll do another further manualy fix for it, @RobinHerbots you may want to check your git ocnfigs ;)

@PeterDaveHello ,

I did the commit from WSL on my work laptop, ... git wasn't really configured ;-)

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 e962d75 CI test failed ❗️

@RobinHerbots please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25726 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

@RobinHerbots got it! Would you mind to fix this one?

==========ERROR==========
Found file with dos format: ajax/libs/inputmask/package.json, please use `dos2unix` to convert it to unix format!
==========ERROR==========
@PeterBot
Copy link
Member

PeterBot left a comment

@RobinHerbots congratulations! ed74c8e CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25735, thank you 😀

@RobinHerbots

This comment has been minimized.

Copy link
Author

RobinHerbots commented Feb 6, 2019

@PeterDaveHello,

Ok, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment