New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue-bootstrap-typeahead by package.json #13250

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@TheRealChrisS
Copy link

TheRealChrisS commented Feb 9, 2019

Pull request template for new library

Pull request for issue: #
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.
  • Pull request is sent from a non-master branch with a meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@PeterBot PeterBot requested review from dakshshah96 , extend1994 , sashberd and sufuf3 Feb 9, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

@TheRealChrisS congratulations! 5204fe8 CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25785, thank you 😀

{
"basePath": "dist",
"files": [
"**/*"

This comment has been minimized.

@extend1994

extend1994 Feb 11, 2019

Member

Let's use **/!(*.common.*|*.html) to exclude common.js and .html files.

@TheRealChrisS TheRealChrisS changed the title Created package.json Add vue-bootstrap-typeahead by package.json Feb 11, 2019

Changed npmFileMap.files definition
... as suggested by extend1994
@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 a9bf230 CI test failed ❗️

@TheRealChrisS please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25803 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@extend1994

This comment has been minimized.

Copy link
Member

extend1994 commented Feb 15, 2019

Hi @TheRealChrisS
I planned to help squash the commits and import versions but found the PR state was "wants to merge 2 commits into cdnjs:master from unknown repository" Could you check what's wrong? Thanks.

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 15, 2019

@extend1994 Unknown repository means the forked repository has been deleted 😥

@extend1994

This comment has been minimized.

Copy link
Member

extend1994 commented Feb 15, 2019

@PeterDaveHello I once thought of it. Meanwhile, I saw https://github.com/TheRealChrisS/cdnjs/tree/add-vue-bootstrap-typeahead. So I think it would be better to check this issue with @TheRealChrisS. Thanks for the reminder 🙂

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 15, 2019

@extend1994 Once the forked repo was deleted, the result can be undone, what you saw should be a newly forked one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment