New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] Add bootstrap4-duallistbox with npm auto-update via single package.json #13253

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@olafcm
Copy link

olafcm commented Feb 12, 2019

Pull request template for new library

Pull request for issue: #
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.
  • Pull request is sent from a non-master branch with a meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@PeterBot PeterBot requested review from dakshshah96 , extend1994 , sashberd and sufuf3 Feb 12, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 422f2ba CI test failed ❗️

@olafcm please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25824 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 6c4af41 CI test failed ❗️

@olafcm please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25825 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 2b9adea CI test failed ❗️

@olafcm please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25827 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 cc5d132 CI test failed ❗️

@olafcm please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25829 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 ca2b225 CI test failed ❗️

@olafcm please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25830 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@olafcm

This comment has been minimized.

Copy link
Author

olafcm commented Feb 12, 2019

This pull request is almost ready for merge.
How to resolve this last issue:

/ajax/libs/bootstrap4-duallistbox/4.0.1/bootstrap-duallistbox.min.js does not exist but is referenced in package.json

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 12, 2019

@olafcm removal of the verion info will resolve it

@PeterBot
Copy link
Member

PeterBot left a comment

@olafcm congratulations! 7ccfb30 CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25831, thank you 😀

@olafcm

This comment has been minimized.

Copy link
Author

olafcm commented Feb 12, 2019

@PeterDaveHello That worked perfect, thank you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment