Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with git repos - part1 #13543

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@xtuc
Copy link
Member

xtuc commented Nov 5, 2019

No description provided.

@PeterBot PeterBot requested a review from ryankirkman Nov 5, 2019
Copy link
Member

PeterBot left a comment

Oops 😨 c9a40ca CI test failed ❗️

@xtuc please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/29138 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

Copy link
Member

PeterBot left a comment

@xtuc congratulations! 433d121 CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/29139, thank you 😀

@zackbloom zackbloom self-requested a review Nov 5, 2019
Copy link
Collaborator

zackbloom left a comment

🎉 Thanks for doing this @xtuc!

@zackbloom zackbloom requested a review from PeterDaveHello Nov 5, 2019
Copy link
Member

MattIPv4 left a comment

Lgtm.

If @PeterDaveHello is around, we should get them to once over this as they're most familiar with the setup.

@xtuc xtuc changed the base branch from master to next Nov 5, 2019
@xtuc xtuc merged commit 433d121 into cdnjs:next Nov 5, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/drone/pr the build was successful
Details
@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Nov 5, 2019

Thanks, not sure what I can do here right now, this looks huge to me to be reviewed, consider of the model how cdnjs works, once the assets are merged into master branch (I see it's next not master here) and hosted, the hash is calculated, anything wrong could be very hard to be fixed 🤔 I think we still have some discussions undergoing, maybe can wait a little bit to make sure everything is correct.

@xtuc xtuc deleted the xtuc:sven/update3 branch Nov 5, 2019
@zackbloom

This comment has been minimized.

Copy link
Collaborator

zackbloom commented Nov 5, 2019

Is there another way to get things up to date you can think of @PeterDaveHello?

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Nov 5, 2019

@zackbloom as I mentioned earlier in the mail, the bot may be better in this case. Though it can't handle all the new versions, at least the added ones would usually be no mistake,

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Nov 5, 2019

Note that I ran the autoupdater https://github.com/cdnjs/autoupdate

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Nov 8, 2019

Forgot to update here, since I saw the huge PR here, and don't know more details yet, I just spend some time to bring the bot up again, so it can buy us more time to deal with all the things and details. The bot is basically use the autoupdater to check updates, but do more additional check to make sure the file/directory structure broken, I'll suggest to use autoupdate tool with manual or bot checking to make sure everything is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.