Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add zxcvbn password strength estimation library #224

Closed
wants to merge 1 commit into from

3 participants

@jarinudom

No description provided.

@ryankirkman
Owner

Hi mate, how did you arrive at the 1.0 version? I can't seem to find a tag in the github repo denoting version 1.0

@jarinudom

Yeah there's no tag, so I looked at some other libraries that didn't have tags either and figured that was the way to do it. If there's a different way to handle libraries that don't have tags in Git please let me know and I will change it.

@ryankirkman
Owner

Hmm, @lowe would it be possible to add a version number to the script?

@lowe

Hey Ryan, sure. I'm fixing a few small bugs today and will add a 1.0 tag right after. Cheers -dan

@ryankirkman
Owner

Thanks @jarinudom , I used the v1.0 tag from @lowe to create a new commit using your package.json in 3a7f84c

@jarinudom

Awesome, thanks :)

I noticed that the version of zxcvbn-async.js that you added pulls the main file (zxcvbn.js) from Dropbox (like it does in @lowe's repo). I changed it in the version I added to pull zxcvbn.js from CDNJS via the URL: http://cdnjs.cloudflare.com/ajax/libs/zxcvbn/1.0/zxcvbn.js

I think maybe that should be changed?

@lowe

Yeah, I'm not sure what the best call is there. I want people to be able to drop zxcvbn-async.js into their site and have it start working immediately, which is why i started with a full url.

@jarinudom

Oh yeah I agree, was just suggesting to change the URL inside of zxcvbn-async.js so that both files are pulled from CDNJS instead of Dropbox. Don't want you to get your Dropbox account suspended for having too many hits on one file (if they even do that?) :)

@lowe

haha yeah i've made sure i won't trigger any rate limiting for that url. you can certainly change it for your fork though!

@jarinudom

Haha yeah, sorry my comment was more directed at @ryankirkman :)

@ryankirkman
Owner

@jarinudom yeah mate, good idea

@ryankirkman
Owner

Ok, I updated zxcvbn-async.js to use a protocol relative url to cdnjs's zxcvbn.js scriptin this commit: fc6caf8

@jarinudom

Awesome possum. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 10, 2012
  1. @jarinudom
This page is out of date. Refresh to see the latest.
View
1  ajax/libs/zxcvbn/1.0/zxcvbn-async.js
@@ -0,0 +1 @@
+(function(){var a;a=function(){var a,b;b=document.createElement("script");b.src="http://cdnjs.cloudflare.com/ajax/libs/zxcvbn/1.0/zxcvbn.js";b.type="text/javascript";b.async=!0;a=document.getElementsByTagName("script")[0];return a.parentNode.insertBefore(b,a)};null!=window.attachEvent?window.attachEvent("onload",a):window.addEventListener("load",a,!1)}).call(this);
View
40 ajax/libs/zxcvbn/1.0/zxcvbn.js
40 additions, 0 deletions not shown
View
34 ajax/libs/zxcvbn/package.json
@@ -0,0 +1,34 @@
+{
+ "name": "zxcvbn",
+ "version": "1.0",
+ "filename": "zscvbn-async.js",
+ "homepage": "http://tech.dropbox.com/?p=165",
+ "description": "Realistic password strength estimation, based on common words, patterns, and keyboard adjacency.",
+ "keywords": [
+ "passwords",
+ "forms",
+ "security"
+ ],
+ "maintainers": [
+ {
+ "name": "Dan Wheeler",
+ "email": "dan@dropbox.com",
+ "web": "https://github.com/lowe"
+ }
+ ],
+ "bugs": {
+ "web": "https://github.com/lowe/zxcvbn/issues"
+ },
+ "licenses": [
+ {
+ "type": "MIT",
+ "url": "https://github.com/lowe/zxcvbn/blob/master/LICENSE.txt"
+ }
+ ],
+ "repositories": [
+ {
+ "type": "git",
+ "url": "git@github.com:lowe/zxcvbn.git"
+ }
+ ]
+}
Something went wrong with that request. Please try again.