Add zxcvbn password strength estimation library #224

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

No description provided.

Owner

ryankirkman commented Apr 15, 2012

Hi mate, how did you arrive at the 1.0 version? I can't seem to find a tag in the github repo denoting version 1.0

Yeah there's no tag, so I looked at some other libraries that didn't have tags either and figured that was the way to do it. If there's a different way to handle libraries that don't have tags in Git please let me know and I will change it.

Owner

ryankirkman commented Apr 15, 2012

Hmm, @lowe would it be possible to add a version number to the script?

lowe commented Apr 16, 2012

Hey Ryan, sure. I'm fixing a few small bugs today and will add a 1.0 tag right after. Cheers -dan

Owner

ryankirkman commented Apr 19, 2012

Thanks @jarinudom , I used the v1.0 tag from @lowe to create a new commit using your package.json in 3a7f84c

Awesome, thanks :)

I noticed that the version of zxcvbn-async.js that you added pulls the main file (zxcvbn.js) from Dropbox (like it does in @lowe's repo). I changed it in the version I added to pull zxcvbn.js from CDNJS via the URL: http://cdnjs.cloudflare.com/ajax/libs/zxcvbn/1.0/zxcvbn.js

I think maybe that should be changed?

lowe commented Apr 19, 2012

Yeah, I'm not sure what the best call is there. I want people to be able to drop zxcvbn-async.js into their site and have it start working immediately, which is why i started with a full url.

Oh yeah I agree, was just suggesting to change the URL inside of zxcvbn-async.js so that both files are pulled from CDNJS instead of Dropbox. Don't want you to get your Dropbox account suspended for having too many hits on one file (if they even do that?) :)

lowe commented Apr 19, 2012

haha yeah i've made sure i won't trigger any rate limiting for that url. you can certainly change it for your fork though!

Haha yeah, sorry my comment was more directed at @ryankirkman :)

Owner

ryankirkman commented Apr 19, 2012

@jarinudom yeah mate, good idea

Owner

ryankirkman commented Apr 19, 2012

Ok, I updated zxcvbn-async.js to use a protocol relative url to cdnjs's zxcvbn.js scriptin this commit: fc6caf8

Awesome possum. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment