Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improve dependency managment #2666

Merged
merged 1 commit into from Mar 13, 2014

Conversation

Projects
None yet
3 participants
Contributor

zdroid commented Feb 14, 2014

  • Remove duplicate dependencies
  • Remove path as it's native module
  • Update dependencies
  • Avoid setting .patch in dependency version numbers as they may become outdated. Whenever, we can add .patch if it's required (e.g. from ~1.0 to ~1.0.1).
  • Add David badges
Zlatan Vasović Improve dependency managment
- Remove duplicate dependencies
- Remove path as it's native module
- Update dependencies
- Avoid setting .patch in dependency version numbers as they may become outdated. Whenever, we can add .patch if it's required (e.g. from ~1.0 to ~1.0.1).
- Add David badges
38a5e8e
Contributor

petecooper commented Feb 18, 2014

Hey @zdroid - just to let you know I've seen this, and that I'm tagging in @thomasdavis & @ryankirkman for comment on these changes.

Contributor

zdroid commented Feb 18, 2014

Thanks. If you don't like ~1.0 syntax I can change it to ~1.0.0.

Contributor

petecooper commented Feb 18, 2014

Now you mention it, I have a feeling that Travis will wig out over x.x versioning as it's not semver-friendly; switching it to x.x.x would keep things in line.

Travis is a fickle thing and easy to anger, so we should play nice as far as we can.

Contributor

zdroid commented Feb 18, 2014

No, this is also semver-compatible when you add ~ as it automatically adds
patch number. But yes, ~1.0.0 looks nicer than ~1.0.

2014-02-18 18:35 GMT+01:00 Pete Cooper notifications@github.com:

Now you mention it, I have a feeling that Travis will wig out over x.x
versioning as it's not semver-friendly; switching it to x.x.x would keep
things in line.

Travis is a fickle thing and easy to anger, so we should play nice as far
as we can.


Reply to this email directly or view it on GitHubhttps://github.com/cdnjs/cdnjs/pull/2666#issuecomment-35410564
.

Zlatan Vasović - ZDroid

Contributor

petecooper commented Feb 18, 2014

Ah, I didn't know that - thanks for the education, sir.

Contributor

zdroid commented Feb 18, 2014

:)

2014-02-18 18:40 GMT+01:00 Pete Cooper notifications@github.com:

Ah, I didn't know that - thanks for the education, sir.


Reply to this email directly or view it on GitHubhttps://github.com/cdnjs/cdnjs/pull/2666#issuecomment-35411168
.

Zlatan Vasović - ZDroid

Contributor

petecooper commented Mar 13, 2014

Bumping this.

@thomasdavis and @ryankirkman - the changes to README.md look OK to me, are you happy with the package.json modifications?

Owner

ryankirkman commented Mar 13, 2014

Yep, looks fine to me

On Thursday, March 13, 2014, Pete Cooper notifications@github.com wrote:

Bumping this.

@thomasdavis https://github.com/thomasdavis and @ryankirkmanhttps://github.com/ryankirkman- the changes to
README.md look OK to me, are you happy with the package.jsonmodifications?

Reply to this email directly or view it on GitHubhttps://github.com/cdnjs/cdnjs/pull/2666#issuecomment-37522844
.

Contributor

petecooper commented Mar 13, 2014

Cool beans - thanks, @ryankirkman. I'll close and merge. Thanks, @zdroid.

@petecooper petecooper pushed a commit that referenced this pull request Mar 13, 2014

Pete Cooper Merge pull request #2666 from ZDroid/update-deps
Improve dependency managment
510f098

@petecooper petecooper merged commit 510f098 into cdnjs:master Mar 13, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

zdroid commented Mar 13, 2014

😄

@zdroid zdroid deleted the zdroid:update-deps branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment