angular.js 1.2.13 and updating other 1.2.x versions with proper minified js and map files #2693

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

willbutler commented Feb 19, 2014

All of the files in this commit (except for the minified css) were downloaded from http://code.angularjs.org/. Versions 1.2.11 - 1.2.13 are new. Versions 1.2.0rc1 - 1.2.9 were updated with the correct minified files and map files.

Contributor

drewfreyling commented Feb 19, 2014

What was wrong with the previous minified files?

Contributor

willbutler commented Feb 20, 2014

They don't match the original minified files available from http://code.angularjs.org and don't work with the source maps. The 1.2.10 version was the only one that had the original minified files and source maps.

Contributor

drewfreyling commented Feb 20, 2014

Fair call. I'll see if @ryankirkman is ok with this because we generally don't like updating existing code on the CDN.

willbutler closed this Feb 20, 2014

willbutler reopened this Feb 20, 2014

Contributor

willbutler commented Feb 20, 2014

Doh. Clicked the wrong button. Anyway, if there is an issue, I'd be happy to submit a new pull request with the new versions only.

Contributor

drewfreyling commented Mar 24, 2014

Do you have any issues with this @ryankirkman ?

Contributor

petecooper commented Mar 28, 2014

This has been hanging around a while - I'm going to take a look and see if it can be sorted today. @willbutler - thanks for your patience with this.

@petecooper petecooper pushed a commit that referenced this pull request Mar 28, 2014

Pete Cooper Housekeeping on angular - no version change (part 1 of ?)
Unifying with http://code.angularjs.org - see
#2693 for background, hat tip to
@willbutler.

Supplied, pre-made angular.min.js are smaller than existing copies on
cdnJS. Processed from 0.9.0 to 0.9.19 so far. More to follow.
4a1984c

@petecooper petecooper pushed a commit that referenced this pull request Mar 28, 2014

Pete Cooper Housekeeping on angular - no version change (part 2 of ?)
Unifying with http://code.angularjs.org - see #2693 for background, hat
tip to
@willbutler.

Adding .map files for 1.3.0-beta* and syncing files from
http://code.angularjs.org
526959e

@petecooper petecooper pushed a commit that referenced this pull request Mar 28, 2014

Pete Cooper Housekeeping on angular - no version change (part 3 of ?)
Unifying with http://code.angularjs.org - see #2693 for background, hat
tip to @willbutler.

Adding missing .map files for 1.2.* and syncing files from
http://code.angularjs.org
1575993

@petecooper petecooper pushed a commit that referenced this pull request Mar 28, 2014

Pete Cooper Housekeeping on angular - no version change (part 4 of ?)
Unifying with http://code.angularjs.org - see #2693 for background, hat
tip to @willbutler.

Adding missing files for 1.1.* and syncing files from
http://code.angularjs.org
f6663d4

@petecooper petecooper pushed a commit that referenced this pull request Mar 28, 2014

Pete Cooper Housekeeping on angular - no version change (part 5 of 5)
Unifying with http://code.angularjs.org - see #2693 for background, hat
tip to @willbutler.

Adding missing files for 1.0.* and syncing files from
http://code.angularjs.org

This concludes the angular.js maintenance for now. Thank you for flying
Air cdnJS, we wish you a safe onward journey.
a863718
Contributor

petecooper commented Mar 28, 2014

Hey @willbutler - I've done some stuff to angular.js that I think covers the non-update changes in this PR:

1.2.13 was already added in another PR, so there's no requirement to add that in.

The cdnJS mirror or Angular now has .map files where available, and original .min.js files from the source. You're more familiar with the library than I am, so I'd be grateful if you could check over the structure and resolve/alert us to any issues.

I will close this PR for now - thanks for spotting the goof and sorry it's taken this long to get resolved. Please open a new issue if you spot any snags.

petecooper closed this Mar 28, 2014

Contributor

willbutler commented Mar 28, 2014

Thanks @petecooper! I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment