Added angular-translate 2.0.0 and 1.1.1 to CDNJS. #2714

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@LordSputnik

All files downloaded from https://github.com/angular-translate . Since before 2.0.0, versions of the translation file loader scripts don't seem to correspond with versions of the main script, the following tags were used for version 1.1.1:

1.1.1
angular-translate.min.js - 1.1.1
angular-translate-loader-partial.min.js - 0.2.0
angular-translate-loader-url.min.js - 0.1.4
angular-translate-loader-static-files.min.js - 0.1.6

Perhaps @PascalPrecht could confirm these are correct/and or add in any files he thinks should be in this package?

@PascalPrecht

@LordSputnik our latest release angular-translate 2.0.0?

@LordSputnik

Yes, I included the files from the tags "2.0.0" of the "bower-angular-translate", "bower-angular-translate-loader-partial", "bower-angular-translate-loader-static-files" and "bower-angular-translate-loader-url" repositories. And for 1.1.1, I used the versions in my first comment. Both versions are included, in separate folders.

@petecooper

Travis build barfed due to earlier failure elsewhere. Will restart for completeness.

@petecooper

Hi @LordSputnik - thanks for the pull request. Travis is now working following an earlier failure, unrelated to your commit. I see numbered angular-translate releases here:

https://github.com/angular-translate/angular-translate/releases

As a rule of thumb, using numbered releases is useful because there's less of a grey area with tags/branches etc, especially with actively developed projects. If you can ensure they correspond to the files you've committed, I'm happy to merge and close.

@LordSputnik

@PascalPrecht I've tried but I'm unable to build angular-translate myself, I get some dependency issues with grunt. Could you possibly verify that the files I've included here are correct for the two versions in the package? (Or, if it's easier, make a new pull request with files you know to be correct)

@petecooper

Hi @LordSputnik - in the interests of housekeeping and getting this library online, I'm going to check out your branch, check against the files here: https://github.com/angular-translate/angular-translate/releases then add in 2.0.1 - should be done within 15 minutes, barring any hurdles.

Edit: oh, now I understand - it's split across multiple libraries - so that link I posted is not relevant. I'll poke around, back in a bit.

@petecooper

OK, so I've taken a closer look at this - it appears that the files in this PR are split over multiple libraries under the https://github.com/angular-translate umbrella:

...and so on. As these are all distinct libraries under the same organisation, I'm going to suggest splitting this PR into different libraries on cdnJS - this will provide a lot more flexibility moving forward, along with an easier maintenance route, and aldo avoid pushing multiple GitHub libraries into one cdnJS library.

I'm going to tag the boys in charge - @drewfreyling, @ryankirkman and @thomasdavis - to see if they have any comments.

@ryankirkman
cdnjs member

@petecooper I agree - keeping them split out puts us in a more flexible position moving forward. I say go ahead!

@petecooper

Right on, @ryankirkman - I will attend to this later today.

@LordSputnik

Sorry I haven't been more useful on this - would you like me do the preparation for the split libraries?

@petecooper

@LordSputnik - thank you, that would be really useful. If you're able to show what libraries should be available for someone using angular-translate, we can start to put the pieces into place. I've got some time tonight (Friday evening, UTC) to do the heavy lifting and commits if you're able advise on the components that should be included.

@LordSputnik

Unfortunately I had a bit of a PC crisis this evening (reinstalling both Windows and Ubuntu tomorrow). So only just reading this now...

These four are the ones I've used before:
angular-translate
angular-translate-loader-partial
angular-translate-loader-static-files
angular-translate-loader-url

angular-translate is the core package, and the other three modules extend the functionality by allowing different ways to load translation data.

@petecooper

OK, cool - I'll make a start on that today.

@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Removing non-live `angular-translate` library
Splitting into component parts with subsequent commits:
`angular-translate`, `angular-translate-loader-partial`,
`angular-translate-loader-static-files` and
`angular-translate-loader-url`.

See #2714 /cc @LordSputnik
cc7d4ca
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate 4118d8e
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-partial
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-part
ial/releases/*.zip

2 of 4 libraries required to fix
#2714 /cc @lordSputnik
20e38f9
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-static-files
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-stat
ic-files/releases/*.zip

3 of 4 libraries required to fix
#2714 /cc @lordSputnik
d15f553
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-url
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-url/
releases/*.zip

4 of 4 libraries required to fix
#2714 /cc @lordSputnik
d5a4bb9
@petecooper

OK, the angular-translate files are ready and all pass npm, but there are unrelated build errors that are causing snags with Code Climate (#2900). I will merge the angular-translate libraries into master and then close this PR.

@petecooper petecooper pushed a commit that closed this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate 677cf7f
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-partial
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-part
ial/releases/*.zip

2 of 4 libraries required to fix #2714
115a2f9
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-static-files
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-stat
ic-files/releases/*.zip

3 of 4 libraries required to fix #2714
023f1b5
@petecooper petecooper pushed a commit that referenced this pull request Mar 29, 2014
Pete Cooper Adding bower-angular-translate-loader-url
Sources:
https://github.com/angular-translate/bower-angular-translate-loader-url/
releases/*.zip

4 of 4 libraries required to fix #2714
5c6ffe6
@petecooper

@LordSputnik @PascalPrecht - angular-translate components now merged into master on cdnJS. They should be live on the site very soon.

@PascalPrecht

@petecooper Hey, sorry for being off on this thread for longer time.. Now what has to be done if there's a new version? Do I have to send a PR here for each new release? Because we're planning weekly releases.

@PascalPrecht

Oh and there are also other extensions besides the async loaders.

@petecooper

@PascalPrecht - no worries, I'm glad we've sorted it out and got the process in motion.

For releases, we can update from npm automatically or from a pull request for the new files. Using npm makes the process much easier, but merging a properly-formatted PR is usually a pretty quick job, too. For more info, take a look at README.md.

For other extensions that fall under the angular-translate banner, you could open a fresh PR to add them - please keep one library per commit as it helps with peer review overall. You're welcome to ask questions if you have them.

@PascalPrecht

Sounds all pretty sane to me! Thanks for clarifying! Expect upcoming PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment