New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub corner banner #258

Closed
MattIPv4 opened this Issue Dec 11, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@MattIPv4
Copy link
Member

MattIPv4 commented Dec 11, 2018

Hiya,

Is there a reason behind the bizarre media width requirement for the GitHub banner to be rotated and positioned correctly? (https://github.com/cdnjs/new-website/blob/master/public/css/main.css#L33-L56)

I'm guessing the aim is for it to be not rotated on mobile, but 1333px is just a tiny bit beyond what a normal mobile media query would be?

@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Dec 19, 2018

@ryankirkman GitHub blame blames you for the relevant code, any thoughts?

@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Jan 3, 2019

Nvm, it appears to be because it clips into the nav bar, will be resolved in #262 and the follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment