Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public/css/*.css needs to be linted #299

Open
MattIPv4 opened this issue Sep 10, 2019 · 3 comments · May be fixed by #302

Comments

@MattIPv4
Copy link
Member

commented Sep 10, 2019

We are adding linting for all main files relating to the website. We have already implemented eslint for the backend scripts and linting for the HTML templates and front-end JS are in the works.

We should also be linting the main css files that are used for the site to ensure they also keep a good code style standard going forward.

@MattIPv4 MattIPv4 self-assigned this Sep 10, 2019

@MattIPv4 MattIPv4 added the 🧪 tests label Sep 10, 2019

@MattIPv4 MattIPv4 changed the title public/css/main.css needs to be linted public/css/*.css needs to be linted Sep 10, 2019

@drewfreyling

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

What are you thinking? Stylelint?

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Hey @drewfreyling, yup, I think I plan to go for stylelint over csslint.
Do you have any preference on what base rules we use, or should I just build up a config based around what we have already?

@MattIPv4 MattIPv4 added this to the Pre-redesign milestone Sep 11, 2019

@drewfreyling

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@MattIPv4 I normally just use stylelint-config-standard rules

@MattIPv4 MattIPv4 referenced a pull request that will close this issue Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.