New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Fix throng dependency vulnerability #256

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
3 participants
@jmgaya
Copy link
Contributor

jmgaya commented Nov 15, 2018

Here is the linked issue

@@ -44,6 +44,6 @@
"marked": "^0.3.12",
"mustache": "^2.3.0",
"newline-remove": "^1.0.2",
"throng": "^2.0.1"
"throng": "^4.0.0"

This comment has been minimized.

@jmgaya

jmgaya Nov 15, 2018

Contributor

The Node version should be higher than 4, so, given the engines node in the package.json, this update should be OK

@MattIPv4 MattIPv4 referenced this pull request Jan 1, 2019

Closed

A load of updates #262

@MattIPv4
Copy link
Member

MattIPv4 left a comment

LGTM

@MattIPv4 MattIPv4 requested a review from PeterDaveHello Jan 2, 2019

@MattIPv4 MattIPv4 added the enhancement label Jan 2, 2019

@MattIPv4 MattIPv4 changed the title Fixed throng dependency and updated webServer.js [Website] Fixe throng dependency vulnerability Jan 2, 2019

@MattIPv4 MattIPv4 changed the title [Website] Fixe throng dependency vulnerability [Website] Fix throng dependency vulnerability Jan 2, 2019

@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Jan 10, 2019

Resolves #255
Resolves #264

@PeterDaveHello
Copy link
Member

PeterDaveHello left a comment

LGTM, thanks a lot!

@PeterDaveHello PeterDaveHello merged commit 3178643 into cdnjs:master Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment