Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `package-lock.json` to .gitignore #278

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MattIPv4
Copy link
Member

commented May 8, 2019

Resolves #257 by adding the package-lock.json file to .gitignore.

@MattIPv4 MattIPv4 requested a review from PeterDaveHello May 8, 2019

@drewfreyling

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Why do we want to ignore it?

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@drewfreyling It isn't something that we track, so having in the gitignore file makes life easier for all involved.

@Glennmen

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

I don't see why you would want to ignore package-lock.json, doesn't having this file improve development because everyone tests/develops using the same package versions.

@Glennmen

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

There is actually a package-lock.json file in the public/ folder but hasn't been updated: https://github.com/cdnjs/new-website/blob/master/public/packages.min.json

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@Glennmen That is a minified version of all the packages we host on cdnjs, not related to the npm package versions for the site itself.

Edit: I totally agree however that we should be tracking the lock file, but @PeterDaveHello said in #257 that we don't need to track it, so it's best to ignore it to make the intention clear.

@Glennmen

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@MattIPv4 My bad 😅

Peter said: I don't think we really need to add it., maybe he didn't think about package version consistency between different local setups.

@drewfreyling

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Consistency between dev and ci servers is a major plus for keeping it. I'd argue we do need to keep track of it.

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@PeterDaveHello What are your thoughts on this?
We (Drew/Glenn/I) are in agreement that we should actually be tracking this file in the repo, not having it untracked (and ignored in this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.