Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML linting (html-validate & linthtml) #296

Open
wants to merge 14 commits into
base: master
from

Conversation

@MattIPv4
Copy link
Member

commented Sep 8, 2019

This adds html-validate & linthtml to the test suite for new-website with custom rulesets based on the existing style we have.

This brings all existing HTML files up-to-standard following these lint rules.

This also removes all unused templates so that the repository has a cleaner HTML based to work from in future.

@MattIPv4 MattIPv4 added the 🧪 tests label Sep 8, 2019

@MattIPv4 MattIPv4 self-assigned this Sep 8, 2019

@MattIPv4 MattIPv4 force-pushed the MattIPv4-html-lint branch from 0212494 to 68c0f7b Sep 9, 2019

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

GitHub is sorting these commits in the wrong order, they are actually in a more logical order in git.
image

templates/library.html Outdated Show resolved Hide resolved
templates/about.html Outdated Show resolved Hide resolved
templates/about.html Outdated Show resolved Hide resolved
templates/about.html Outdated Show resolved Hide resolved
templates/library.html Outdated Show resolved Hide resolved

@MattIPv4 MattIPv4 force-pushed the MattIPv4-html-lint branch from 24ebad3 to 767b655 Sep 10, 2019

@MattIPv4 MattIPv4 added this to the Pre-redesign milestone Sep 11, 2019

@MattIPv4 MattIPv4 force-pushed the MattIPv4-html-lint branch from 767b655 to bce8eb8 Sep 12, 2019

@MattIPv4 MattIPv4 changed the title 🚧 Add HTML linting (html-validator & linthtml) Add HTML linting (html-validate & linthtml) Sep 12, 2019

@MattIPv4 MattIPv4 requested review from PeterDaveHello and drewfreyling Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.