Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs-extra #2889

Merged
merged 3 commits into from Mar 16, 2021
Merged

Remove fs-extra #2889

merged 3 commits into from Mar 16, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Mar 15, 2021

There's more detail in the commits.

@code-asher code-asher requested a review from a team as a code owner March 15, 2021 21:25
jawnsy
jawnsy previously approved these changes Mar 15, 2021
src/node/cli.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@code-asher
Copy link
Member Author

code-asher commented Mar 15, 2021

Realized I didn't need my own unlinkf and rmdir with recursive works on files so I just pushed a change to use rmdir instead. Although semantically it feels a bit weird.

jsjoeio
jsjoeio previously approved these changes Mar 16, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Remove the Mac directory copy instead of refactoring it since we've had
this for a long time now and I think it's safe to assume that users
running code-server on Mac don't have the old directory anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants