Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add isConnected check #3271

Merged
merged 2 commits into from Apr 30, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 30, 2021

This PR adds a new check for e2e tests to ensure we have a connection.

Changes

  • add isConnected method to CodeServer
  • add e2e test for isConnected
  • refactor reloadUntilEditorIsVisible to reloadUntilEditorIsReady (checks visibility and connection)

Screenshots

image

Checklist

  • tested locally
  • added a test

Fixes #3270

@jsjoeio jsjoeio self-assigned this Apr 30, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Apr 30, 2021
@jsjoeio jsjoeio added this to 🚧 In progress in Improve Testing via automation Apr 30, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #3271 (dcdde3d) into main (0d9fe6f) will not change coverage.
The diff coverage is n/a.

❗ Current head dcdde3d differs from pull request most recent head cde3057. Consider uploading reports for the commit cde3057 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3271   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9fe6f...cde3057. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio/check-connection-e2e branch from 120caab to a5926aa Compare April 30, 2021 20:36
@jsjoeio jsjoeio marked this pull request as ready for review April 30, 2021 20:37
@jsjoeio jsjoeio requested a review from a team as a code owner April 30, 2021 20:37
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

test/e2e/models/CodeServer.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio force-pushed the jsjoeio/check-connection-e2e branch from dcdde3d to cde3057 Compare April 30, 2021 20:44
@jsjoeio jsjoeio added the merge when passing Merge the PR automatically once all status checks have passed label Apr 30, 2021
@repo-ranger repo-ranger bot merged commit f5a3033 into main Apr 30, 2021
Improve Testing automation moved this from 🚧 In progress to ✅ Done Apr 30, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio/check-connection-e2e branch April 30, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when passing Merge the PR automatically once all status checks have passed testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev]: add check to e2e tests for connection
2 participants